Do not crash when encountering empty stack traces #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent JVMs run with OmitStackTraceInFastThrow enabled by default. When an exception occurs several times, the stack trace is no more generated, but COSBench still tries to parse it, and fails miserably. One solution is to run COSBench with -XX:-OmitStackTraceInFastThrow. For extra security we will also ignore such empty stack traces. Fixes: intel-cloud#323 Fixes: intel-cloud#331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent JVMs run with OmitStackTraceInFastThrow enabled by default. When an exception occurs several times, the stack trace is no more generated, but COSBench still tries to parse it and fails miserably. One solution is to run COSBench with
-XX:-OmitStackTraceInFastThrow. For extra security, we will also ignore such empty stack traces.Fixes: intel-cloud#323
Fixes: intel-cloud#331