Skip to content

Commit

Permalink
Move optional export_path to end
Browse files Browse the repository at this point in the history
As export_path is currently not documented, optional and unsupported, it should be placed at the end of the list and assigned a default value. Otherwise, the JSONRPC server will complain about a missing export_path argument. However, if clients supply a value, it's likely not None, hence unsupported
  • Loading branch information
dsonck92 authored Aug 1, 2020
1 parent aca5f4a commit 450cb81
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion targetd/fs.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ def nfs_export_list(req):
return rc


def nfs_export_add(req, host, path, export_path, options):
def nfs_export_add(req, host, path, options, export_path=None):

if export_path is not None:
raise TargetdError(TargetdError.NFS_NO_SUPPORT,
Expand Down

0 comments on commit 450cb81

Please sign in to comment.