Skip to content

Commit

Permalink
spec: make dist tag optional (#659)
Browse files Browse the repository at this point in the history
Technically the %{dist} RPM macro is optional, so Fedora's convention is
to use a question mark in the Release field.

https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/

Practically speaking, %{dist} is almost always defined, so the question
mark is not necessary, but this silences a warning in one of Red Hat's
internal linters.
  • Loading branch information
ktdreyer authored Jun 15, 2021
1 parent 11fcb66 commit a34cd2f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tcmu-runner.spec
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Version: 1.5.4
URL: https://github.com/open-iscsi/tcmu-runner

#%define _RC
Release: %{?_RC:%{_RC}}%{dist}
Release: %{?_RC:%{_RC}}%{?dist}
BuildRoot: %(mktemp -udp %{_tmppath}/%{name}-%{version}%{?_RC:-%{_RC}})
Source: %{name}-%{version}%{?_RC:-%{_RC}}.tar.gz
ExclusiveOS: Linux
Expand Down

0 comments on commit a34cd2f

Please sign in to comment.