Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode absolute install prefixes #683

Open
fogti opened this issue Sep 4, 2022 · 2 comments · May be fixed by #684
Open

Don't hardcode absolute install prefixes #683

fogti opened this issue Sep 4, 2022 · 2 comments · May be fixed by #684

Comments

@fogti
Copy link

fogti commented Sep 4, 2022

Currently, the CMakeLists.txt and *.conf_install.cmake.in files contain absolute install paths, that is, not relative to ${CMAKE_INSTALL_PREFIX}. This makes packaging this program unusually hard.
e.g.

tcmu-runner/CMakeLists.txt

Lines 326 to 331 in 364ae61

install(FILES org.kernel.TCMUService1.service
DESTINATION /usr/share/dbus-1/system-services)
install(FILES tcmu-runner.conf DESTINATION /etc/dbus-1/system.d)
if (SUPPORT_SYSTEMD)
install(FILES tcmu-runner.service DESTINATION /usr/lib/systemd/system/)
endif (SUPPORT_SYSTEMD)

@AndersonTorres
Copy link

AndersonTorres commented Sep 4, 2022

Additionally, I suggest the use of GNU install dirs module conventions.

@fogti
Copy link
Author

fogti commented Sep 4, 2022

Interestingly, at least include(GNUInstallDirs) is already used. So this is definitively a bug.

fogti added a commit to fogti/tcmu-runner that referenced this issue Sep 4, 2022
Fixes open-iscsi#683

> Currently, the CMakeLists.txt and *.conf_install.cmake.in files contain
> absolute install paths, that is, not relative to ${CMAKE_INSTALL_PREFIX}.
> This makes packaging this program unusually hard.

Signed-off-by: Alain Zscheile <zseri.devel@ytrizja.de>
fogti added a commit to fogti/tcmu-runner that referenced this issue Sep 5, 2022
Fixes open-iscsi#683

> Currently, the CMakeLists.txt and *.conf_install.cmake.in files contain
> absolute install paths, that is, not relative to ${CMAKE_INSTALL_PREFIX}.
> This makes packaging this program unusually hard.

Signed-off-by: Alain Zscheile <zseri.devel@ytrizja.de>
fogti added a commit to fogti/tcmu-runner that referenced this issue Sep 5, 2022
Fixes open-iscsi#683

> Currently, the CMakeLists.txt and *.conf_install.cmake.in files contain
> absolute install paths, that is, not relative to ${CMAKE_INSTALL_PREFIX}.
> This makes packaging this program unusually hard.

Signed-off-by: Alain Zscheile <zseri.devel@ytrizja.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants