Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner/lib: use uint64_t for dev_size #360

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikechristie
Copy link
Collaborator

Use uint64_t for dev_size to prevent issues with 32 bit setups.

Attached is the kernel patch that will also be pushed.

dev-size64-target-pending.txt

@mikechristie
Copy link
Collaborator Author

Attached is the correct patch for the kernel.

dev-size64-target-pending-v2.txt

Use uint64_t for dev_size to prevent issues with 32 bit setups.
@JuniorJPDJ
Copy link
Contributor

Attached is the correct patch for the kernel.

Did you maybe try to send this patch to linux mainling lists?

@mikechristie
Copy link
Collaborator Author

Attached is the correct patch for the kernel.

Did you maybe try to send this patch to linux mainling lists?

The kernel patch is merged upstream already. It was only attached in this PR to make it easier for people to test.

The userspace parts in this PR are not merged so it's still open. I don't work on this project anymore, so feel free to take up the issue/PR/code.

@JuniorJPDJ
Copy link
Contributor

JuniorJPDJ commented Jul 14, 2021

Well, would be cool if someone would maintain this software, but it seems pretty dead :/

@JuniorJPDJ
Copy link
Contributor

JuniorJPDJ commented Jul 14, 2021

Your commit does loads of other things, not only uses uint64_t for dev size.
Could you please split it and name it correctly?
Then I could rebase it and play with them a bit to make sure everything works.

@JuniorJPDJ
Copy link
Contributor

@lxbsz what do you think about this PR? It seems to fix some issues I've stepped into on 32-bit arches, but would need rebase and also probably spliting into more commits.

@lxbsz
Copy link
Collaborator

lxbsz commented Sep 16, 2021

@lxbsz what do you think about this PR? It seems to fix some issues I've stepped into on 32-bit arches, but would need rebase and also probably spliting into more commits.

I am okay with it. If you can test on the 32-bit arches, please go ahead to take it.
I will test it after that.

@lxbsz lxbsz changed the base branch from master to main August 10, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants