Lock bounce fixes #477
Merged
Lock bounce fixes #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 11, 2018 21:46
Don't escalate to dropping the iscsi connection if the lock is taken from us. The initiator is most likely doing it's initialization and so the lock is bouncing between paths during the device probe stage. Signed-off-by: Mike Christie <mchristi@redhat.com>
We only need the log metadata for explicit alua. Implicit failover's tag is a bogus value. This has rbd not set the metadata when it is not valid, so the code matches the comments now. Signed-off-by: Mike Christie <mchristi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a issue commonly seen with Linux initiators where during dm-multipath device initialization the lock bounces between gateways so much tcmu-runner ends up escalating the issue by dropping the iscsi connection by disabling the TPG. This results in probe related IO failing and/or dm-multipath path failures.