-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add travis-integration for build verification #542
base: main
Are you sure you want to change the base?
Conversation
Looks nice. I am not familiar with setting it up. Besides your patch I also need to enable it on the repo right? Something like described here: https://github.com/mbonaci/mbo-storm/wiki/Integrate-Travis-CI-with-your-GitHub-repo or I can do directly here: |
extra/docker/Dockerfile.centos7
Outdated
@@ -0,0 +1,41 @@ | |||
# Dockerfile for testing the build of gluster-block based on centos7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix up the comment since you made it more generic. Same with the other file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it was unintentional. I have copied the template from gluster-block repo. Fixed it now.
Thanks!
@pkalever @mikechristie https://github.com/marketplace/travis-ci/plan/MDIyOk1hcmtldHBsYWNlTGlzdGluZ1BsYW43MA==#pricing-and-setup Thanks. |
The docker build only does build and no testing added at this point. We can start adding some tests soon. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
@mikechristie right, you need to enable travis on the repo, Should help turning travis ON. Thanks! |
Just some heads up. I am leaving on PTO and was not able to finish this before I left. I will handle when I get back on April 8th. |
Sure, no problem Mike! |
The docker build only does build and no testing added at this point.
We can start adding some tests soon.
Signed-off-by: Prasanna Kumar Kalever prasanna.kalever@redhat.com