glfs: retry 5 times to wait the meta data updated successfully #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the 'gluster-block modify' we can hit one issue in the same client with multi-precesses, here is the gluster-blockd and tcmu-runner. We do glfs_ftruncate in gluster-blockd to resize the volume file and then in tcmu-runner to check the size by using the glfs_lstat but get the old size, which hasn't been updated yet. But from the mountpoint's ls command, we can see that the size is already upated to new one. Here we will went to wait for most 5 seconds and retry 5 times to make sure the cache has been flushed successfully to the volume. Fixes: gluster/gluster-block#204 Signed-off-by: Xiubo Li <xiubli@redhat.com>
|
Patch looks sane to me. Let me know when you guys have reviewed and I will merge it. |
Hi Mike, Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the 'gluster-block modify' we can hit one issue in the same
client with multi-precesses, here is the gluster-blockd and
tcmu-runner.
We do glfs_ftruncate in gluster-blockd to resize the volume file
and then in tcmu-runner to check the size by using the glfs_lstat
but get the old size, which hasn't been updated yet.
But from the mountpoint's ls command, we can see that the size is
already upated to new one.
Here we will went to wait for most 5 seconds and retry 5 times to
make sure the cache has been flushed successfully to the volume.
Fixes: gluster/gluster-block#204
Signed-off-by: Xiubo Li xiubli@redhat.com