dyn-config: try to read it again in case the pagecache is not flushed out #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… out In-case if the editor (vim) follows write to a new file (.swp, .tmp ..) and move it to actual file name later. There is a window, where we will encounter one case that the file data is not flushed to the disk, so in another process(here) when reading it will be empty. Let just wait and try again. Signed-off-by: Xiubo Li <xiubli@redhat.com>
|
|
||
| buf = malloc(TCMU_MAX_CFG_FILE_SIZE); | ||
| if (!buf) | ||
| return -ENOMEM; | ||
|
|
||
| retry: | ||
| count++; |
There was a problem hiding this comment.
I think the tabbing/spacing got messed up for the count++ line.
| */ | ||
| if (count <= 5 && (len == 0 || ret == -ENOENT)) { | ||
| tcmu_dbg("failed to read the config from file, retrying (%d/5) times\n", | ||
| count); |
There was a problem hiding this comment.
Same for the "count);" line here. I think the tabbing/spacing got messed up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-case if the editor (vim) follows write to a new file (.swp, .tmp ..)
and move it to actual file name later. There is a window, where we will
encounter one case that the file data is not flushed to the disk, so in
another process(here) when reading it will be empty.
Let just wait and try again.
Signed-off-by: Xiubo Li xiubli@redhat.com