-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation on musl libc #664
Conversation
And could you split the commit into small ones with each one fixes a single issue. |
Ok ;) Gimme few minutes. |
and similar - there was more than one error like this, but point is musl doesn't support this (
and similar (4 errors like this) - this is error while compiling on 32-bit architectures (armhf, armv7, x86). |
With this patches and one from OpenSuse guy |
I reworded commits and added descriptions to them |
This allows to preserve compatibility with 32-bit and 64-bit architectures. Fixes compilation problems like: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'time_t' {aka 'long long int'}
This permits to preserve musl libc compatibility and fixes compile time problems like: error: implicit declaration of function 'assert_perror';
This fixes musl libc compatibility and fixes compilation time error like: error: unknown type name 'pthread_t'
This fixes compilation time errors like: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'pthread_t' {aka 'struct __pthread *'}
This allows to preserve compatiblity with musl libc which lacks this function
Just tested it on armv7 (32-bit) with fbo backend. This means #609 and those commits fix 32-bit issues not only for compilation but also for runtime. |
Cool, I will test it later this week. Thanks @JuniorJPDJ |
Now it would be cool to merge #609 and it would make some packagers not patch tcmu-runner at all ;D |
At the same time could help test that ? Currently I didn't have the env, for me I need to install one someday later. |
I already tested it, it's included in Alpine Linux patches and I was testing it with this pull. |
Sounds cool. I will work on it recently after my handy fs work. |
Have ever hit the issue @mikechristie mentioned in 9a4a721#r362956473 ? |
I briefly tested it on Alpine Linux and it seems to work.