rbd: misc fixes #673
Merged
rbd: misc fixes #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idryomov
reviewed
Sep 13, 2021
| @@ -216,8 +216,6 @@ static int tcmu_rbd_service_register(struct tcmu_device *dev) | |||
| } | |||
|
|
|||
| ret = tcmu_rbd_report_event(dev); | |||
| if (ret < 0) | |||
| tcmu_dev_err(dev, "Could not update status. (Err %d)\n", ret); | |||
There was a problem hiding this comment.
Is this error message actually redundant in master? I think it was made redundant in #667 so this hunk doesn't belong in this PR.
There was a problem hiding this comment.
This exists in master, there has already one error log in tcmu_rbd_report_event() --> tcmu_rbd_service_status_update().
Not introduced by #667, that PR just switched to use tcmu_rbd_service_status_update() directly.
There was a problem hiding this comment.
I see, looks like I got confused there.
| bool has_lock) | ||
| { | ||
| return 0; |
There was a problem hiding this comment.
Fix "rbd: rbd: ..." in the commit title for this change.
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Xiubo Li <xiubli@redhat.com>
idryomov
approved these changes
Sep 13, 2021
|
Merging it, thanks @idryomov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.