Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis simplifications #2475

Merged
merged 1 commit into from
May 31, 2020
Merged

Conversation

hannesa2
Copy link
Contributor

@hannesa2 hannesa2 commented Jul 19, 2019

It's about modernize this repo.

In general

Because of this multi git submodule setup, it's needs several PR on multiple repos, but as it looks like, the maintainer(s) keep not that much attention on it

What I did:

  • update to most recent build tools
  • update to most recent support lib
  • update to most recent other libs, where it was possible
  • make Travis work with it
  • switch temporary to updated forked git submodules
    (as soon, as the PR's there are merged, this can be removed)
  • removed a workaround commit for supportLib 23
    (btw, the end target should be AndroidX)
  • (temporary ?) removed witness Gradle plugin
    • It can't handle most recent build tools
    • checks are not perfect
    • last commit is from 2014, and last closed issue from 2015: It's the definition of dead
  • But now tests make issues

image

I'm out of ideas.

I'm out of ideas, maybe update of Roboelectric makes sense ? But this needs AndroidX, as far as I observed.

Maybe you can help me, to solve it, or you can uses this PR as basis to continue this work. Or close this PR unmerged

Without help, I'm done here at this point

@hannesa2 hannesa2 changed the title Android Studio 3.4.2 Android Studio 3.4.2 WIP Jul 19, 2019
@hannesa2 hannesa2 force-pushed the AndroidStudio-3.4.2 branch from 58bca94 to 3f9c5d9 Compare October 22, 2019 20:43
@hannesa2 hannesa2 changed the title Android Studio 3.4.2 WIP Android Studio 3.5.1 WIP Oct 22, 2019
@hannesa2 hannesa2 force-pushed the AndroidStudio-3.4.2 branch from 3f9c5d9 to d3301c3 Compare October 23, 2019 05:31
@hannesa2 hannesa2 force-pushed the AndroidStudio-3.4.2 branch 2 times, most recently from 6a1a362 to c24e36d Compare April 29, 2020 04:40
.gitmodules Outdated
@@ -1,6 +1,6 @@
[submodule "extern/openpgp-api-lib"]
path = extern/openpgp-api-lib
url = https://github.com/open-keychain/openpgp-api.git
url = https://github.com/hannesa2/openpgp-api.git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge the PR there and I can switch back to https://github.com/open-keychain/openpgp-api.git

@Valodim
Copy link
Member

Valodim commented May 30, 2020

Hi @hannesa2. I did some major cleanup work in #2553 after some time away from the project. I think I covered everything from this PR, so I'll close this one. If you find something more feel free to open another PR.

@hannesa2 hannesa2 force-pushed the AndroidStudio-3.4.2 branch from c24e36d to e74e8c5 Compare May 30, 2020 20:39
@hannesa2
Copy link
Contributor Author

I'm fine with all. For me the most important thing is keep this repo alive

@hannesa2 hannesa2 force-pushed the AndroidStudio-3.4.2 branch from e74e8c5 to cda9e2b Compare May 30, 2020 20:43
@hannesa2
Copy link
Contributor Author

I rebased it to #2553
So it ends up in just Travis simplifications

@hannesa2 hannesa2 changed the title Android Studio 3.5.1 WIP Travis simplifications May 30, 2020
@hannesa2 hannesa2 force-pushed the AndroidStudio-3.4.2 branch 3 times, most recently from e5c111c to 85bfdc0 Compare May 31, 2020 11:24
@hannesa2 hannesa2 force-pushed the AndroidStudio-3.4.2 branch from 85bfdc0 to ffa23c8 Compare May 31, 2020 11:27
@Valodim
Copy link
Member

Valodim commented May 31, 2020

👍

@Valodim Valodim merged commit 61892a6 into open-keychain:master May 31, 2020
@hannesa2
Copy link
Contributor Author

This Travis is that much broken, I vote to remove it complete and go with #2556 only

@hannesa2
Copy link
Contributor Author

hannesa2 commented May 31, 2020

In parallel I build on my fork to see results
hannesa2#3

because here no CI is running at all, and you don't see how broken all is

image

@hannesa2 hannesa2 deleted the AndroidStudio-3.4.2 branch May 31, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants