Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NASA certification process #926

Merged
merged 8 commits into from
Nov 28, 2024

Conversation

iramosp
Copy link
Member

@iramosp iramosp commented Nov 28, 2024

This PR adds a file explaining the NASA certification process to the Nebula cohort processes and procedures folder.

  • Tagging @doaamkader for content review: Are the steps clear? Any questions we should anticipate?
  • Tagging @NPDebs for technical review after content approval.

👍🎉 First of all, thanks for taking the time to contribute! 🎉👍

FOR CONTRIBUTOR

PR Type:

  • This PR adds a new blog post
  • This PR does something else (explain above)

FOR REVIEWERS

Thanks for taking the time to review! ❤️

Here are the list of things to make sure of:

  • The website builds (a check will fail if not)
  • All images have been added within the Pull Request and they have Alt text
  • If there are paragraphs or text, the key messages are highlighted
  • All internal links (within OLS website) use the {% link path_to_file.md %} format
  • The preview corresponds to the changes described in the Pull Request
  • The code is tidy and passes the linting tests

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for ols-bebatut ready!

Name Link
🔨 Latest commit 4457f69
🔍 Latest deploy log https://app.netlify.com/sites/ols-bebatut/deploys/67483eb0efbc0f000893c0d6
😎 Deploy Preview https://deploy-preview-926--ols-bebatut.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@iramosp iramosp added documentation Improvements or additions to documentation 🚀 Nebula labels Nov 28, 2024
@iramosp iramosp requested review from doaamkader and NPDebs November 28, 2024 03:11
@NPDebs
Copy link
Collaborator

NPDebs commented Nov 28, 2024

Thanks, Irene! 🌟

@doaamkader - Here's a preview of the changes made.

Copy link
Collaborator

@NPDebs NPDebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, this looks good @iramosp! 🎉 Happy to merge after content review from Doaa.

I have added a couple of tweaks in your PR which I should let you know about:

  • Made openscience101.org link clickable.
  • Made Nebula resources findable by adding them to the "Resources" dropdown menu in the navbar.
  • Created a new variable (site.nebula_email) to store the Nebula contact email (nebula-cohort-management@...).
  • Used the variable to replace the explicit mention of the email address.

Let me know if any of these don't sit right with you, or need more clarification. Thanks again!

@doaamkader
Copy link
Collaborator

@iramosp @NPDebs I reviewed the steps and it seems clear for me

@iramosp
Copy link
Member Author

iramosp commented Nov 28, 2024

@doaamkader, thanks for checking!
@NPDebs, thanks for going the extra mile to add those changes!

I think this is ready to merge 🙌

@NPDebs
Copy link
Collaborator

NPDebs commented Nov 28, 2024

Thank you both for the work here! 🥳💪🏽

@NPDebs NPDebs merged commit 1268ec9 into open-life-science:main Nov 28, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🚀 Nebula
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants