Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use selenium-firefox docker image version 2.53.1 #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kabalin
Copy link
Contributor

@kabalin kabalin commented May 17, 2020

Match selenium-firefox version used in https://github.com/moodlehq/moodle-docker (using version 3 will cause failure).

This also adds moodle dir mount to selenium container to allow running file upload
tests (#110 (comment)).

Also remove PROFILE env var in .travis.yml to prevent assumption that
changing its value to firefox will work (it won't if version remains 3).

@james-cnz
Copy link

This change didn't work for me:
-v $HOME/build/moodle:$HOME/build/moodle

I got this error:

In ProcessHelper.php line 97:

The command "git clone --depth=1 --branch MOODLE_38_STABLE git://github.com
/moodle/moodle.git moodle" failed.

Exit Code: 1(General error)

Working directory: /home/travis/build

Output:

Error Output:

Cloning into 'moodle'...
/home/travis/build/moodle/.git: Permission denied

This was using a copy of .travis.dist.yml with NVM changed to 14.0 in addition to the changes here.

The change from Firefox 3 to 2.5.3.1 did get Behat working again for me, though.

@kabalin
Copy link
Contributor Author

kabalin commented May 19, 2020

Thanks @james-cnz, let me trigger travis and see myself. I might be that we need to start selenium docker instance after moodle installation.

Also remove PROFILE env var in .travis.yml to prevent assumption that
changing its value to `firefox` will work (it won't if version remain 3).

Also add moodle dir mount to selenium container to allow running file upload
tests.
@kabalin kabalin force-pushed the selenium-firefox-downgrade branch from 84c9a3a to 0561af9 Compare May 19, 2020 14:52
@james-cnz
Copy link

It works for me now, thanks.

@kabalin
Copy link
Contributor Author

kabalin commented May 20, 2020

Thanks for verifying @james-cnz!

@dvdcastro looks like Travis is no longer enabled on this repo :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants