Fix python test failures

open-metadata · Nov 10, 2023 · 05ee9da · 05ee9da
1 parent de835ba
commit 05ee9da
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/ingestion/tests/integration/ometa/test_ometa_glossary.py b/ingestion/tests/integration/ometa/test_ometa_glossary.py
@@ -528,12 +528,6 @@ def test_patch_glossary_term_references(self):
         self.assertIsNotNone(res)
         self.assertEqual(0, len(res.references))
 
-        # Remove reference when list is empty - fails
-        res = self.metadata.patch_glossary_term_references(
-            entity_id=self.glossary_term_1.id,
-        )
-        self.assertIsNone(res)
-
         # Remove reference when there are many
         self.metadata.patch_glossary_term_references(
             entity_id=self.glossary_term_1.id,

diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java b/openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java
@@ -1898,7 +1898,9 @@ private void updateDescription() {
     private void updateDeleted() {
       if (operation.isPut() || operation.isPatch()) {
         // Update operation can't set delete attributed to true. This can only be done as part of delete operation
-        if (!Objects.equals(updated.getDeleted(), original.getDeleted()) && Boolean.TRUE.equals(updated.getDeleted())) {
+        if (!Objects.equals(updated.getDeleted(), original.getDeleted())
+            && Boolean.TRUE.equals(updated.getDeleted())
+            && changeDescription != null) {
           throw new IllegalArgumentException(CatalogExceptionMessage.readOnlyAttribute(entityType, FIELD_DELETED));
         }
         // PUT or PATCH is restoring the soft-deleted entity