Skip to content

Commit

Permalink
Minor: update git-blmae-ignore-revs, and uncomment ClassificationReso…
Browse files Browse the repository at this point in the history
…urceTest tests code
  • Loading branch information
harshach committed Dec 19, 2023
1 parent 1294f93 commit 2a75c8d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .git-blame-ignore-revs
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8c2a1e415dbe00b89e7105905f0e1e7e6296a5c4
1294f93e15258c4d0ea2f8d4f0b746a6267dd6cc
Binary file removed .pre-commit-config.yaml.swp
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import org.openmetadata.schema.entity.classification.Classification;
import org.openmetadata.schema.entity.classification.Tag;
import org.openmetadata.schema.type.ChangeDescription;
import org.openmetadata.schema.type.ProviderType;
import org.openmetadata.service.Entity;
import org.openmetadata.service.exception.CatalogExceptionMessage;
import org.openmetadata.service.resources.EntityResourceTest;
Expand Down Expand Up @@ -98,17 +99,17 @@ public CreateClassification createRequest(String name) {
@Override
public void validateCreatedEntity(
Classification createdEntity, CreateClassification request, Map<String, String> authHeaders) {
// assertEquals(
// request.getProvider() == null ? ProviderType.USER : request.getProvider(),
// createdEntity.getProvider());
assertEquals(
request.getProvider() == null ? ProviderType.USER : request.getProvider(),
createdEntity.getProvider());
assertEquals(request.getMutuallyExclusive(), createdEntity.getMutuallyExclusive());
}

@Override
public void compareEntities(
Classification expected, Classification updated, Map<String, String> authHeaders) {
// assertEquals(expected.getProvider() == null ? ProviderType.USER : expected.getProvider(),
// updated.getProvider());
assertEquals(expected.getProvider() == null ? ProviderType.USER : expected.getProvider(),
updated.getProvider());
assertEquals(expected.getMutuallyExclusive(), updated.getMutuallyExclusive());
}

Expand Down

0 comments on commit 2a75c8d

Please sign in to comment.