Skip to content

Commit

Permalink
Fix #14590: Improve airflow plugin error message
Browse files Browse the repository at this point in the history
  • Loading branch information
ulixius9 committed Jan 24, 2024
1 parent d228a93 commit 3919438
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ public PipelineServiceClientResponse getServiceStatusInternal() {
// APIs URL not found
if (response.statusCode() == 404) {
return buildUnhealthyStatus(
"Airflow APIs not found. Please follow the installation guide.");
"Airflow APIs not found. Please validate if the OpenMetadata Airflow plugin is installed correctly. Follow [this guide](https://docs.open-metadata.org/v1.2.x/deployment/ingestion/openmetadata) for further details.");
}

return buildUnhealthyStatus(
Expand All @@ -306,7 +306,9 @@ public PipelineServiceClientResponse getServiceStatusInternal() {
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
return buildUnhealthyStatus(
String.format("Failed to get REST status due to [%s].", e.getMessage()));
String.format(
"Failed to get REST status due to [%s] - Please validate if Airflow is up and running.",
e.getMessage()));
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { Space, SpaceProps, Typography } from 'antd';
import { Space, SpaceProps } from 'antd';
import classNames from 'classnames';
import { isEmpty } from 'lodash';
import React, { FC } from 'react';
import { ReactComponent as IconRetry } from '../../../assets/svg/ic-retry-icon.svg';
import { useAirflowStatus } from '../../../hooks/useAirflowStatus';
import RichTextEditorPreviewer from '../../common/RichTextEditor/RichTextEditorPreviewer';
import './airflow-message-banner.less';

const AirflowMessageBanner: FC<SpaceProps> = ({ className }) => {
Expand All @@ -32,7 +33,7 @@ const AirflowMessageBanner: FC<SpaceProps> = ({ className }) => {
data-testid="no-airflow-placeholder"
size={16}>
<IconRetry className="align-middle" height={24} width={24} />
<Typography.Text>{reason}</Typography.Text>
<RichTextEditorPreviewer enableSeeMoreVariant={false} markdown={reason} />
</Space>
);
};
Expand Down

0 comments on commit 3919438

Please sign in to comment.