Skip to content

Commit

Permalink
fix #14292: Tags Page UI issues (#14327)
Browse files Browse the repository at this point in the history
* Fixed modal css & text styling

* fix unnecessary api calls

* address comments

* added locale files

* change widget message & fix unnecessary api calls

* address comments

* fix tags page import

* fix failing cyp test

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
  • Loading branch information
harsh-vador and chirag-madlani authored Dec 19, 2023
1 parent d79654e commit 824307d
Show file tree
Hide file tree
Showing 17 changed files with 587 additions and 536 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const revokeToken = () => {
// Verify the revoke text
cy.get('[data-testid="body-text"]').should(
'contain',
'Are you sure you want to revoke access for JWT token?'
'Are you sure you want to revoke access for JWT Token?'
);
interceptURL('PUT', `/api/v1/users/revokeToken`, 'revokeToken');
// Click on confirm button
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*
* Copyright 2023 Collate.
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* http://www.apache.org/licenses/LICENSE-2.0
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { Classification } from '../../generated/entity/classification/classification';
import { Tag } from '../../generated/entity/classification/tag';
import { DeleteTagsType } from '../../pages/TagsPage/TagsPage.interface';
import { OperationPermission } from '../PermissionProvider/PermissionProvider.interface';

export interface ClassificationDetailsProps {
classificationPermissions: OperationPermission;
isVersionView?: boolean;
currentClassification?: Classification;
deleteTags?: DeleteTagsType;
isEditClassification?: boolean;
isAddingTag?: boolean;
disableEditButton?: boolean;
handleAfterDeleteAction?: () => void;
handleEditTagClick?: (selectedTag: Tag) => void;
handleActionDeleteTag?: (record: Tag) => void;
handleAddNewTagClick?: () => void;
handleEditDescriptionClick?: () => void;
handleCancelEditDescription?: () => void;
handleUpdateClassification?: (
updatedClassification: Classification
) => Promise<void>;
}
export interface ClassificationDetailsRef {
refreshClassificationTags: () => void;
}
Loading

0 comments on commit 824307d

Please sign in to comment.