Minor: improve UI of filters in test case graph

open-metadata · Sep 10, 2024 · c3cddf7 · c3cddf7
1 parent 7f3a9f3
commit c3cddf7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/...i/src/main/resources/ui/src/components/Database/Profiler/TestSummary/TestSummaryGraph.tsx b/...i/src/main/resources/ui/src/components/Database/Profiler/TestSummary/TestSummaryGraph.tsx
@@ -135,6 +135,7 @@ function TestSummaryGraph({
       dataKey: info.label,
       type: 'line',
       color: info.color,
+      inactive: !(activeKeys.length === 0 || activeKeys.includes(info.label)),
     }));
 
     legendPayload.push({
@@ -145,7 +146,7 @@ function TestSummaryGraph({
     } as Payload);
 
     return legendPayload;
-  }, [chartData]);
+  }, [chartData?.information, activeKeys]);
 
   const handleLegendClick: LegendProps['onClick'] = (event) => {
     if (event.dataKey === 'Incident') {
@@ -226,7 +227,7 @@ function TestSummaryGraph({
 
   return (
     <ResponsiveContainer
-      className="bg-white"
+      className="bg-white custom-test-summary-graph"
       id={`${testCaseName}_graph`}
       minHeight={minHeight ?? 400}>
       <ComposedChart

diff --git a/...a-ui/src/main/resources/ui/src/components/Database/Profiler/TestSummary/test-summary.less b/...a-ui/src/main/resources/ui/src/components/Database/Profiler/TestSummary/test-summary.less
@@ -33,3 +33,8 @@
     }
   }
 }
+.custom-test-summary-graph {
+  .recharts-legend-item {
+    cursor: pointer;
+  }
+}
diff --git a/openmetadata-ui/src/main/resources/ui/src/constants/profiler.constant.ts b/openmetadata-ui/src/main/resources/ui/src/constants/profiler.constant.ts
@@ -76,6 +76,8 @@ export const PROFILER_METRIC = [
   'customMetricsProfile',
 ];
 
+export const INCIDENT = 'Incident';
+
 export const PROFILER_FILTER_RANGE: DateFilterType = {
   yesterday: {
     days: 1,