changed to id instead of name in dashboard entity

open-metadata · Sep 16, 2024 · cad211a · cad211a
1 parent f794b7c
commit cad211a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 17 deletions.
diff --git a/ingestion/src/metadata/ingestion/source/dashboard/sigma/client.py b/ingestion/src/metadata/ingestion/source/dashboard/sigma/client.py
@@ -85,26 +85,17 @@ def get_auth_token(self) -> Tuple[str, int]:
         """
         generate auth token
         """
-        try:
-            payload = {"grant_type": "client_credentials"}
-            result = AuthToken(**self.token_client.post("/auth/token", data=payload))
-            return result.access_token, 0
-        except Exception as exc:  # pylint: disable=broad-except
-            logger.debug(traceback.format_exc())
-            logger.error(f"Error fetching Access Token: {exc}")
+        payload = {"grant_type": "client_credentials"}
+        result = AuthToken(**self.token_client.post("/auth/token", data=payload))
+        return result.access_token, 0
 
     def get_dashboards(self) -> Optional[List[Workbook]]:
         """
         method to fetch dashboards from api
         """
-        try:
-            result = WorkBookResponseDetails(**self.client.get("/workbooks"))
-            if result:
-                return result.entries
-        except Exception as exc:  # pylint: disable=broad-except
-            logger.debug(traceback.format_exc())
-            logger.error(f"Error fetching Dashboards List: {exc}")
-        return None
+        result = WorkBookResponseDetails(**self.client.get("/workbooks"))
+        if result:
+            return result.entries
 
     def get_dashboard_detail(self, workbook_id: str) -> Optional[WorkbookDetails]:
         """

diff --git a/ingestion/src/metadata/ingestion/source/dashboard/sigma/metadata.py b/ingestion/src/metadata/ingestion/source/dashboard/sigma/metadata.py
@@ -95,7 +95,7 @@ def yield_dashboard(
         """
         try:
             dashboard_request = CreateDashboardRequest(
-                name=EntityName(str(dashboard_details.name)),
+                name=EntityName(str(dashboard_details.workbookId)),
                 displayName=dashboard_details.name,
                 description=Markdown(dashboard_details.description),
                 charts=[
@@ -172,7 +172,7 @@ def yield_dashboard_lineage_details(
             self.metadata,
             entity_type=LineageDashboard,
             service_name=self.config.serviceName,
-            dashboard_name=str(dashboard_details.name),
+            dashboard_name=str(dashboard_details.workbookId),
         )
         to_entity = self.metadata.get_by_name(
             entity=LineageDashboard,