Fixes #14331 - Add Test Case Incident Manager Migration (#14386)

* feat: add test case resolution task workflow * chore: add migration for test case resolution feature * fix: removed required field for object compatibiity in older migrations * fix: minor testCaseResolution status logic * chore: revert migration for test case incident * chore: update migration file * chore: clean up code * style: fix java stylecheck
open-metadata · Dec 22, 2023 · fe4c353 · fe4c353
1 parent cdddc0c
commit fe4c353
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 7 deletions.
diff --git a/bootstrap/sql/migrations/native/1.3.0/mysql/postDataMigrationSQLScript.sql b/bootstrap/sql/migrations/native/1.3.0/mysql/postDataMigrationSQLScript.sql
@@ -4,5 +4,17 @@ SET json = REPLACE(json, '"customMetricsProfile"', '"customMetrics"');
 
 -- Delete customMetricsProfile from entity_extension
 -- This was not supported on the processing side before 1.3.
-DELETE FROM openmetadata_db.entity_extension ee   
-where extension  like '%customMetrics';
+DELETE FROM entity_extension ee   
+where extension  like '%customMetrics';
+
+-- BEGIN: Incident Manager Migration
+-- STEP 1: Update test case testCaseResult.testCaseFailureStatus field
+UPDATE test_case
+SET json = JSON_REMOVE(json, '$.testCaseResult.testCaseFailureStatus')
+WHERE json -> '$.testCaseResult.testCaseFailureStatus' IS NOT NULL;
+
+
+-- STEP 2: remove all `testCaseFailureStatus` field in test results
+UPDATE data_quality_data_time_series d
+SET json = JSON_REMOVE(json, '$.testCaseFailureStatus');
+-- END: Incident Manager Migration
diff --git a/bootstrap/sql/migrations/native/1.3.0/postgres/postDataMigrationSQLScript.sql b/bootstrap/sql/migrations/native/1.3.0/postgres/postDataMigrationSQLScript.sql
@@ -5,4 +5,13 @@ SET json = REPLACE(json::text, '"customMetricsProfile"', '"customMetrics"')::jso
 -- Delete customMetricsProfile from entity_extension
 -- This was not supported on the processing side before 1.3.
 DELETE FROM entity_extension ee   
-where extension  like '%customMetrics';
+where extension  like '%customMetrics';
+
+-- BEGIN: Incident Manager Migration
+-- STEP 1: Update test case testCaseResult.testCaseFailureStatus field
+UPDATE test_case
+SET json = json::jsonb#-'{testCaseResult,testCaseFailureStatus}';
+-- STEP 2: remove all `testCaseFailureStatus` field in test results
+UPDATE data_quality_data_time_series d
+SET json = json::jsonb#-'{testCaseFailureStatus}';
+-- END: Incident Manager Migration
diff --git a/...vice/src/main/java/org/openmetadata/service/jdbi3/TestCaseResolutionStatusRepository.java b/...vice/src/main/java/org/openmetadata/service/jdbi3/TestCaseResolutionStatusRepository.java
@@ -110,6 +110,7 @@ public TestCaseResolutionStatus createNewRecord(
       TestCaseResolutionStatus recordEntity, String extension, String recordFQN) {
     TestCaseResolutionStatus latestTestCaseFailure =
         getLatestRecord(recordEntity.getTestCaseReference().getFullyQualifiedName());
+
     recordEntity.setStateId(
         ((latestTestCaseFailure != null)
                 && (latestTestCaseFailure.getTestCaseResolutionStatusType()

diff --git a/...ervice/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java b/...ervice/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java
@@ -1770,7 +1770,7 @@ public void assertFieldChange(String fieldName, Object expected, Object actual)
     }
   }
 
-  private ResultList<TestCaseResolutionStatus> getTestCaseFailureStatus(
+  public ResultList<TestCaseResolutionStatus> getTestCaseFailureStatus(
       Long startTs,
       Long endTs,
       String assignee,

diff --git a/openmetadata-spec/src/main/resources/json/schema/tests/basic.json b/openmetadata-spec/src/main/resources/json/schema/tests/basic.json
@@ -90,8 +90,7 @@
             "description": "Reference to the failure status object for the test case result.",
             "$ref": "./testCaseResolutionStatus.json"
         }
-      },
-      "additionalProperties": false
+      }
     },
     "testSuiteExecutionFrequency": {
       "description": "How often the test case should run.",

diff --git a/openmetadata-spec/src/main/resources/json/schema/tests/resolved.json b/openmetadata-spec/src/main/resources/json/schema/tests/resolved.json
@@ -34,6 +34,6 @@
         "$ref": "../type/entityReference.json"
       }
   },
-  "required": ["testCaseFailureReason", "resolvedBy", "testCaseFailureComment"],
+  "required": ["testCaseFailureReason", "testCaseFailureComment"],
   "additionalProperties": false
 }