Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 Release - Permissions Related Errors #11058

Closed
2 tasks done
harshach opened this issue Apr 14, 2023 · 8 comments
Closed
2 tasks done

1.0 Release - Permissions Related Errors #11058

harshach opened this issue Apr 14, 2023 · 8 comments
Assignees
Labels
P0 Highest priority UI UI specific issues

Comments

@harshach
Copy link
Collaborator

harshach commented Apr 14, 2023

  • Remove default role and policy at organization level. Login as non-admin user, Click on Govern -> Glossary we are showing empty page

image

Its redirecting 404 page

image

  • Looks like we do not have any 404 page anymore? ^
@harshach harshach added the UI UI specific issues label Apr 14, 2023
@harshach harshach added the P0 Highest priority label Apr 14, 2023
@harshach
Copy link
Collaborator Author

harshach commented Apr 14, 2023

  • If the user doesn't have viewTests permission we throw an error in explore . We should ignore it and not show the data

image

  • if the user doesn't have permission to view the data we should show the they don't have permission to view the data in the right panel , right now we throw an error notification

image

@harshach
Copy link
Collaborator Author

harshach commented Apr 14, 2023

  • In Organization page, Click on Roles and we show this generic message thats not related to the function --> @Ashish8689

image

We should say "Add A role to {team_name}. This role will be inherited by all the users in this team {team_name} and the all the teams under {team_name}" better text from @sureshms or @ShilpaVernekar

@harshach we have updated and verified this with @ShilpaVernekar
image

@harshach
Copy link
Collaborator Author

harshach commented Apr 14, 2023

  • As a user with viewAll policy I can go to the data my team owned. I can create an announcement on that entity

image

I shouldn't be able to add the announcement if I don't have edit access on that entity cc @sureshms @chirag-madlani

I can add an annoucement but I can't delete the announcement I created
image

I can edit annoucement
image

solution for me , If I do not have edit access lets not allow user to create Annonucement on it .

This is being tracked here -> #11374

@harshach
Copy link
Collaborator Author

harshach commented Apr 14, 2023

  • Select mutually exclusive tags
    image . We throw the error after adding the tags, this can be cumbersome as the user can select 5 tags and 2 of them conflict we throw an error all the other tags are not added.
    Second issue, is visually we show that tags are added but error is thrown , even after clearing the error the tags appear as added until the user refreshes the page. We need to do better here. It will be great if we show that user is selecting mutually exclusive tag while selecting it.

@harshach
Copy link
Collaborator Author

harshach commented Apr 14, 2023

  • If the user doesn't have Edit Tags option the Request Tags and Conversation icons shows at the end out of the way of tags which looks weird

image

@ShilpaVernekar
Copy link
Contributor

Slightly modified the text
cc @harshach @sureshms @chirag-madlani
"Add a Role to {team_name}. This role will be inherited by all the Users in the Team {team_name} as well as all the Teams under {team_name}"

@harshach
Copy link
Collaborator Author

harshach commented Apr 23, 2023

  • default organization policy allows users to set ownership on the entity without owners. This works on the table but not the topic, pipeline, mlmodel, or containers

image

image

image

image

@harshach
Copy link
Collaborator Author

harshach commented Apr 23, 2023

  • user with Data Consumer role which has ViewAll, EditTags, EditDescription doesn't allow edit option for charts

image

Pipeline Tasks doesn't allow add descriptions or tags

image

MlModel doesn't even allow edit tags or description at the entity level

image

Tags are not shown at Container level. The description is allowed to edit
image

Container Schema's description is not allowed to edit or added tags for
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Highest priority UI UI specific issues
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants