Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revisit announcement operation permissions #11374

Closed
3 tasks done
aniketkatkar97 opened this issue May 2, 2023 · 2 comments
Closed
3 tasks done

revisit announcement operation permissions #11374

aniketkatkar97 opened this issue May 2, 2023 · 2 comments
Assignees
@harshach @aniketkatkar97
Labels
backend UI UI specific issues

Comments

@aniketkatkar97
Copy link
Member

aniketkatkar97 commented May 2, 2023 •
edited
Loading

Affected module
UI, backend

  • Backend:

  • User shouldn't be able to add an announcement if he/she doesn't have edit access on the entity

  • User without edit permission can add and edit an announcement but can't delete the announcement created

image

image

  • UI:

  • Ensure the permissions changes for announcements in the UI. (Current behavior from the UI is, if a user has an EditAll access on an asset, he can add and edit an announcement. A user, irrespective of the permissions can delete the announcement if he/she is the author of the announcement.)

To Reproduce

Screenshots or steps to reproduce

Expected behavior
A clear and concise description of what you expected to happen.

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8]
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.
@aniketkatkar97 aniketkatkar97 added UI UI specific issues backend labels May 2, 2023
@aniketkatkar97 aniketkatkar97 mentioned this issue May 2, 2023
Closed
2 tasks
@harshach harshach moved this to APIs & Backend in Release 1.1 May 8, 2023
@harshach harshach moved this from APIs & Backend to Roles & Policies in Release 1.1 May 8, 2023
@harshach harshach removed this from Release 1.1 Jul 29, 2023
@chirag-madlani chirag-madlani assigned sureshms and unassigned harshach Sep 11, 2023
@harshach harshach moved this to Backend - Bugs & Minor Features in Release 1.3.0 Oct 22, 2023
@aniketkatkar97
Copy link
Member Author

aniketkatkar97 commented Dec 1, 2023 •
edited
Loading

  • Announcement widget visibility and position changes

@harshach harshach removed this from Release 1.3.0 Dec 11, 2023
chirag-madlani pushed a commit that referenced this issue Jan 5, 2024
@aniketkatkar97 @harshach
#11374: Removed the announcement knowledge panel customisability (#14196
5a0880c 
)

* Removed the announcement knowledge panel
Announcements widget will only show on landing page if  announcements are present

* renamed the MyDataPageV1 to  MyDataPage

* added unit tests for the MyDataPage component

* Added unit tests for customizablePage and MyDataPage

* removed the API call to fetch announcements in customizeMyData component

* added unit tests for CustomizeMyData component

* added unit tests for EmptyWidgetPlaceholder component

* Added unit tests for AddWidgetModal components

* updated the data test ids for widgets

* updated the data test id for KPI widget

* added data-testids related to customize page flow

* Added tests for persona CRUD operations

* localization change for other languages

* updated data test ids related to customize landing page

* updated the persona flow spec

* added cypress tests for customizable landing page flow

* fixed unit tests

* updated the my data page logic to add announcement widget

* fixed empty widget placeholder not showing after resetting the layout

* Minor: Fix the DocStoreResourceTest

* remove the border for announcement widget

---------

Co-authored-by: Sriharsha Chintalapani <harsha@getcollate.io>
@harshach harshach moved this to Backend - Bugs & Minor Features in Release 1.4.0 Jan 26, 2024
@aniketkatkar97
Copy link
Member Author

@harshach the UI side changes for this were done in the #14196 PR. Do we need anything else here? If not we can close this issue.

@harshach harshach removed this from Release 1.4.1 Jun 24, 2024
@harshach harshach assigned harshach and unassigned sureshms Jun 24, 2024
@harshach harshach removed this from Release 1.7.0 Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshach harshach

@aniketkatkar97 aniketkatkar97

Labels
backend UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@harshach @sureshms @aniketkatkar97