Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classification api is failing having dot in it's name on certain condition #13860

Closed
Ashish8689 opened this issue Nov 6, 2023 · 1 comment · Fixed by #14209
Closed

Classification api is failing having dot in it's name on certain condition #13860

Ashish8689 opened this issue Nov 6, 2023 · 1 comment · Fixed by #14209
Assignees
@harshach
Labels
backend

Comments

@Ashish8689
Copy link
Contributor

Ashish8689 commented Nov 6, 2023 •
edited
Loading

Affected module
Does it impact the UI, backend or Ingestion Framework?
backend

Describe the bug
A clear and concise description of what the bug is.

  • After renaming any classification name with having dot in it's name. We are not getting child terms in it.
  • Getting classification by name API is also failing in case of classification having dot in it's name end . Example DataProduct.
  • API : api/v1/classifications/name/%22DataProduct.%22?fields=usageCount,termCount

To Reproduce

Screenshots or steps to reproduce

Screen.Recording.2023-11-06.at.6.35.51.PM.mov
Screen.Recording.2023-11-06.at.6.36.54.PM.mov

Expected behavior
A clear and concise description of what you expected to happen.

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8]
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.
@karanh37
Copy link
Contributor

This issue is also reproducible for Glossary terms, Domain and Data Products.
cc - @07Himank

@harshach harshach removed this from Release 1.3.0 Nov 29, 2023
@harshach harshach moved this to Backend - Bugs & Minor Features in Release 1.2.3 Nov 30, 2023
harshach added a commit that referenced this issue Dec 2, 2023
@harshach
#13860: Classification api is failing having dot in it's name
8950c6e
@harshach harshach mentioned this issue Dec 2, 2023
Merged
9 tasks
harshach added a commit that referenced this issue Dec 3, 2023
@harshach
#13860: Classification api is failing having dot in it's name (#14209)
59d0e82
@harshach harshach moved this from Backend - Bugs & Minor Features to Done in Release 1.2.3 Dec 3, 2023
harshach added a commit that referenced this issue Dec 5, 2023
@harshach
#13860: Classification api is failing having dot in it's name (#14209)
1a0e420
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this issue Dec 15, 2023
@harshach
open-metadata#13860: Classification api is failing having dot in it's…
003959f 
… name (open-metadata#14209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshach harshach

Labels
backend
Projects
No open projects
Release 1.2.3
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#13860: Classification api is failing having dot in it's name open-metadata/OpenMetadata
3 participants
@harshach @karanh37 @Ashish8689