Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelling a Test connection doesn't cancel it's API calls #13913

Closed
Ashish8689 opened this issue Nov 9, 2023 · 0 comments · Fixed by #19190
Closed

Cancelling a Test connection doesn't cancel it's API calls #13913

Ashish8689 opened this issue Nov 9, 2023 · 0 comments · Fixed by #19190
Assignees
@Ashish8689
Labels
P0 Highest priority UI UI specific issues

Comments

@Ashish8689
Copy link
Contributor

Affected module
Does it impact the UI, backend or Ingestion Framework?
UI

Issue from #13316 (comment)

Describe the bug
A clear and concise description of what the bug is.

  • Cancelling a Test connection doesn't cancel it's API calls

To Reproduce

Screenshots or steps to reproduce

Expected behavior
A clear and concise description of what you expected to happen.

  • should cancel all API calls if the test connection was got cancel

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8]
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.
@Ashish8689 Ashish8689 added the UI UI specific issues label Nov 9, 2023
@Ashish8689 Ashish8689 self-assigned this Nov 9, 2023
@Ashish8689 Ashish8689 mentioned this issue Nov 9, 2023
Closed
3 tasks
@harshach harshach removed this from Release 1.3.0 Nov 30, 2023
@harshach harshach moved this to UI - Bugs & Minor Features in Release 1.4.0 Feb 13, 2024
@chirag-madlani chirag-madlani added the P1 High priority label Apr 1, 2024
@harshach harshach removed this from Release 1.4.0 Apr 5, 2024
@harshach harshach added P0 Highest priority and removed P1 High priority labels Aug 10, 2024
@harshach harshach moved this to Integration in Release 1.7.0 Dec 14, 2024
@harshach harshach removed this from Release 1.7.0 Dec 14, 2024
@harshach harshach moved this to Integration in Release 1.6.2 Dec 14, 2024
@Ashish8689 Ashish8689 mentioned this issue Dec 29, 2024
Merged
9 tasks
Ashish8689 added a commit that referenced this issue Jan 7, 2025
@Ashish8689
#13913: supported test connection api cancellation (#19190)
a6f81a9 
* supported test connection api cancellation

* minor improvement

* fix the error handling in the intervalAPI calls

* added the useAbortController hook and minor changes

* supported delete workflow if anu api is cancelled

* fix sonar issue and updated the modal button

* fix sonar and playwright issue

* minor fix around test

* reverted the modal textual changes as per comments
@github-project-automation github-project-automation bot moved this from Integration to Done in Release 1.6.2 Jan 7, 2025
github-actions bot pushed a commit that referenced this issue Jan 7, 2025
@Ashish8689
#13913: supported test connection api cancellation (#19190)
2109501 
* supported test connection api cancellation

* minor improvement

* fix the error handling in the intervalAPI calls

* added the useAbortController hook and minor changes

* supported delete workflow if anu api is cancelled

* fix sonar issue and updated the modal button

* fix sonar and playwright issue

* minor fix around test

* reverted the modal textual changes as per comments

(cherry picked from commit a6f81a9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ashish8689 Ashish8689

Labels
P0 Highest priority UI UI specific issues
Projects
No open projects
Release 1.6.2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#13913: supported test connection api cancellation open-metadata/OpenMetadata
3 participants
@harshach @chirag-madlani @Ashish8689