Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Tier search is not working in advance search #14326

Closed
ShaileshParmar11 opened this issue Dec 11, 2023 · 3 comments · Fixed by #14780
Closed

UI: Tier search is not working in advance search #14326

ShaileshParmar11 opened this issue Dec 11, 2023 · 3 comments · Fixed by #14780
Assignees
@karanh37
Labels
UI UI specific issues

Comments

@ShaileshParmar11
Copy link
Contributor

Affected module
Does it impact the UI, backend or Ingestion Framework?
Backend

Describe the bug
A clear and concise description of what the bug is.
Search for tier in advance search is not working,

  • Go to explore
  • Click on Advanced search
  • select tier from dropdown
  • select any condition
  • Search tier in criteria

To Reproduce

Screenshots or steps to reproduce

Expected behavior
A clear and concise description of what you expected to happen.

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8]
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.
@07Himank
Copy link
Contributor

@karanh37 verify at your end .. if we can fix this from UI side

@07Himank 07Himank added the UI UI specific issues label Dec 11, 2023
@harshach harshach moved this to Backend - Bugs & Minor Features in Release 1.3.0 Dec 11, 2023
@harshach
Copy link
Collaborator

harshach commented Jan 5, 2024

@karanh37 @07Himank is this backedn or UI issue?

@karanh37
Copy link
Contributor

karanh37 commented Jan 5, 2024 •
edited
Loading

@harshach It's a UI issue.
After the lowercase changes of Aggregation data, this has stopped working.
Need to update this on UI to now be passing lowercase data for filters.

@harshach harshach removed the backend label Jan 5, 2024
@harshach harshach moved this from Backend - Bugs & Minor Features to UI - Bugs & Minor Features in Release 1.3.0 Jan 5, 2024
@Sachin-chaurasiya Sachin-chaurasiya changed the title Backend: Tier search is not working in advance search UI: Tier search is not working in advance search Jan 16, 2024
@Abhishek332 Abhishek332 mentioned this issue Jan 23, 2024
Merged
chirag-madlani pushed a commit that referenced this issue Jan 23, 2024
@Abhishek332
fix(#14326): tier dropdown is not working in advance search (#14780)
9c92bea 
* improvement in advance search based on custom property

* fix a reading undefined property issue

* wip: advance search based on tier

* some code cleanup and improvement

* some fixes

* fix: ui flicker when advanceSearched is apply and refresh the page

* some cleanup

* no need to call customproperty api call, if entity not suppport customProperties

* minor change

* fix: autocomplete not working in tier search option in advance search modal

* added unit test for advance search provider component

* some cleanup

* added testcase for open modal

* added testcase for resetAllFilters method

* removed unwanted code

* added e2e test for testing tier advance search

* fix: e2e search flow for single field

* fix: string field not working after giving listValues in TierSearch

* fix: group query e2e test fix

* used asyncFetch way to get the tierOptions synchronously

* some cleanup

* remove unwanted lines

* some cleanup

* fix: selected option show option value instead of option title
harshach pushed a commit that referenced this issue Jan 24, 2024
@Abhishek332 @harshach
fix(#14326): tier dropdown is not working in advance search (#14780)
8d61948 
* improvement in advance search based on custom property

* fix a reading undefined property issue

* wip: advance search based on tier

* some code cleanup and improvement

* some fixes

* fix: ui flicker when advanceSearched is apply and refresh the page

* some cleanup

* no need to call customproperty api call, if entity not suppport customProperties

* minor change

* fix: autocomplete not working in tier search option in advance search modal

* added unit test for advance search provider component

* some cleanup

* added testcase for open modal

* added testcase for resetAllFilters method

* removed unwanted code

* added e2e test for testing tier advance search

* fix: e2e search flow for single field

* fix: string field not working after giving listValues in TierSearch

* fix: group query e2e test fix

* used asyncFetch way to get the tierOptions synchronously

* some cleanup

* remove unwanted lines

* some cleanup

* fix: selected option show option value instead of option title
@pmbrull pmbrull moved this from UI - Bugs & Minor Features to Done in Release 1.3.0 Jan 24, 2024
Abhishek332 added a commit to Abhishek332/OpenMetadata that referenced this issue Jan 25, 2024
@Abhishek332
fix(open-metadata#14326): tier dropdown is not working in advance sea…
f1ac240 
…rch (open-metadata#14780)

* improvement in advance search based on custom property

* fix a reading undefined property issue

* wip: advance search based on tier

* some code cleanup and improvement

* some fixes

* fix: ui flicker when advanceSearched is apply and refresh the page

* some cleanup

* no need to call customproperty api call, if entity not suppport customProperties

* minor change

* fix: autocomplete not working in tier search option in advance search modal

* added unit test for advance search provider component

* some cleanup

* added testcase for open modal

* added testcase for resetAllFilters method

* removed unwanted code

* added e2e test for testing tier advance search

* fix: e2e search flow for single field

* fix: string field not working after giving listValues in TierSearch

* fix: group query e2e test fix

* used asyncFetch way to get the tierOptions synchronously

* some cleanup

* remove unwanted lines

* some cleanup

* fix: selected option show option value instead of option title
harshach added a commit that referenced this issue Feb 1, 2024
@harshach @pmbrull
@ulixius9 @ayush-shah @chirag-madlani @kwgdaig @TeddyCr @OnkarVO7 @Ashish8689 @Abhishek332 @luzlab @karanh37
Fix #14786: Suggestions API (#14821)
2e95fcb 
* Fix #14786: Suggestions API

* Handle suggestions in ometa

* Minor: Optimise Databricks Client (#14776)

* MINOR - Fix SP topology context & Looker usage context (#14816)

* MINOR - Fix SP topology context & Looker usage context

* MINOR - Fix SP topology context & Looker usage context

* Fix tests

* Fixes #14598: Fix Tags / Labels ingestion on includeTags as False (#14782)

* fix(ui): password error message for char limits (#14808)

* fix(ui): password error message for char limits

* fix java side code

* Fixes #13556: Support for Salesforce table description ingestion (#14733)

* ISSUE-13556: Add suport for Salesforce table description ingestion

* ISSUE-13556: Remove unnecessary blank line

* ISSUE-13556: Fix to get description for each table

---------

Co-authored-by: Teddy <teddy.crepineau@gmail.com>

* MINOR - Better handling of Ingestion Pipeline Status (#14792)

* MINOR - Better handling of Ingestion Pipeline Status

* format

* format

* MINOR: Added table validation for cost analysis data (#14793)

* Added validation for cost analysis source

* centralized life cycle logic

* CYPRESS: simplify side navigation click in cypress (#14818)

* simplify side navigation click in cypress

* make sidbar item uses common enum

* fix cypress failure of outside import

* fix(#14326): tier dropdown is not working in advance search (#14780)

* improvement in advance search based on custom property

* fix a reading undefined property issue

* wip: advance search based on tier

* some code cleanup and improvement

* some fixes

* fix: ui flicker when advanceSearched is apply and refresh the page

* some cleanup

* no need to call customproperty api call, if entity not suppport customProperties

* minor change

* fix: autocomplete not working in tier search option in advance search modal

* added unit test for advance search provider component

* some cleanup

* added testcase for open modal

* added testcase for resetAllFilters method

* removed unwanted code

* added e2e test for testing tier advance search

* fix: e2e search flow for single field

* fix: string field not working after giving listValues in TierSearch

* fix: group query e2e test fix

* used asyncFetch way to get the tierOptions synchronously

* some cleanup

* remove unwanted lines

* some cleanup

* fix: selected option show option value instead of option title

* fix(minor): update skip icon for executions (#14809)

* Fixes #14803: ignore capitalization when confirming deletes  (#14804)

* ignore case when confirming deletes

* Test confirmation of deletes works when case differs 

Added test case for 'delete' as the confirmation text.

* minor(config): update openmetadata-ui code reviewers (#14823)

* Add Tests

* Add list/accept/reject apis

* initial ui changes

* localisation

* show suggestion for empty description

* ui feedbacks

* Fix permission check for entities without owner

* Fix entityLink and add tests

* Add update suggestion WIP

* Fix test

* Fix PUT and Pagination

* Fix styling

* update test

* Update status

* add OM server connection in apps

* add permissions check

* Fix CI

* Remove TODO

* Fix feedResourceTest

* fix unit tests

* add private configs for apps

* add private configs for apps

* fix update application icons

* minor center align icon

* add private configs for apps

* Format

* Fix pydantic gen

* Remove token

* Update name

* Rework private conf

* Fix apps

* Fix apps

* Format

* Format

* show metapilot only if its installed

---------

Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com>
Co-authored-by: Mayur Singal <39544459+ulixius9@users.noreply.github.com>
Co-authored-by: Ayush Shah <ayush@getcollate.io>
Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Co-authored-by: kwgdaig <18678754+kwgdaig@users.noreply.github.com>
Co-authored-by: Teddy <teddy.crepineau@gmail.com>
Co-authored-by: Onkar Ravgan <onkar.10r@gmail.com>
Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Co-authored-by: Abhishek Porwal <80886271+Abhishek332@users.noreply.github.com>
Co-authored-by: Carlo Q <carlo@machina.bio>
Co-authored-by: karanh37 <karanh37@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karanh37 karanh37

Labels
UI UI specific issues
Projects
No open projects
Release 1.3.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#14326): tier dropdown is not working in advance search Abhishek332/OpenMetadata
4 participants
@harshach @karanh37 @ShaileshParmar11 @07Himank