Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test case name's length limitation-DBT #14554

Closed
zwbill82 opened this issue Jan 3, 2024 · 3 comments · Fixed by #14815
Closed

test case name's length limitation-DBT #14554

zwbill82 opened this issue Jan 3, 2024 · 3 comments · Fixed by #14815
Assignees
Labels
data quality UI UI specific issues

Comments

@zwbill82
Copy link

zwbill82 commented Jan 3, 2024

Affected module
Does it impact the UI, backend or Ingestion Framework?

Ingestion(it may impact the UI and backend)

Describe the bug
A clear and concise description of what the bug is.
we're using OM 1.2.3 to parse DBT manifest/run_result/catalog.json,
our test case's name is very long, like 'assert_stg_fact_pnl__regular_channel_storage_fee_regular_storage_fee__equal__channel_storagee_fee_all_storage_fee_daily_where_fee_type_is_regular', and there is 145 charaters.

To Reproduce

create a singular test case in DBT, naming it more than 128 characters.
then create an ingestion to get it, and you'll encounter the error

Expected behavior
OM can handle the long name test cases

Version:

  • OS: Ubuntu 18.04.6 LTS
  • Python version:
  • OpenMetadata version: 1.2.3
  • OpenMetadata Ingestion package version: 1.2.3

Additional context
the log is here

[2024-01-03T05:43:05.244+0000] {metadata.py:912} ERROR - Failed to capture tests results for node: assert_stg_fact_pnl__fcst_channel_storage_fee_product_id_and_channel_id__not_in__regular_channel_storage_fee Entity already exists
[2024-01-03T05:43:05.245+0000] {topology_runner.py:94} DEBUG - Processing stage: type_=<class 'metadata.generated.schema.api.tests.createTestDefinition.CreateTestDefinitionRequest'> processor='create_dbt_tests_definition' context=None nullable=False must_return=False cache_all=False clear_cache=False overwrite=True consumer=None cache_entities=False use_cache=False
[2024-01-03T05:43:05.245+0000] {metadata.py:753} DEBUG - Processing DBT Tests Definition for node: assert_stg_fact_pnl__regular_channel_storage_fee_regular_storage_fee__equal__channel_storagee_fee_all_storage_fee_daily_where_fee_type_is_regular
[2024-01-03T05:43:05.262+0000] {status.py:65} WARNING - Failed to parse the node to capture tests 1 validation error for CreateTestDefinitionRequest
name -> __root__
  ensure this value has at most 128 characters (type=value_error.any_str.max_length; limit_value=128)
@harshach
Copy link
Collaborator

harshach commented Jan 3, 2024

@TeddyCr we can increase the limitation to 256 characters
@chirag-madlani we should look at if the UI works with longer names

@chirag-madlani
Copy link
Collaborator

@ShaileshParmar11 Please help here if needed, Thanks

@chirag-madlani chirag-madlani removed their assignment Jan 3, 2024
@harshach harshach moved this to Data Quality - Teddy, Pere, Harsha, Shailesh, Rupesh in Release 1.3.0 Jan 5, 2024
@pmbrull pmbrull assigned OnkarVO7 and unassigned TeddyCr Jan 16, 2024
@pmbrull pmbrull added the UI UI specific issues label Jan 16, 2024
@OnkarVO7
Copy link
Contributor

After increasing the limit to 256 the test names are getting ingested correctly.

Attaching some screenshots of long name test cases. Image 1 and 2 looks good IMO, in 3rd image name goes out of screen
cc: @ShaileshParmar11 @pmbrull

image image image

@pmbrull pmbrull moved this from Data Quality - Teddy, Pere, Harsha, Shailesh, Rupesh to Done in Release 1.3.0 Jan 23, 2024
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this issue Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data quality UI UI specific issues
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants