Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting last test case result throw an error #14851

Closed
TeddyCr opened this issue Jan 24, 2024 · 0 comments · Fixed by #14868
Closed

Deleting last test case result throw an error #14851

TeddyCr opened this issue Jan 24, 2024 · 0 comments · Fixed by #14868
Assignees
Labels

Comments

@TeddyCr
Copy link
Contributor

TeddyCr commented Jan 24, 2024

Affected module
Backend

Describe the bug
When deleting the last test case result when trying to update the test suite summary status will throw an error - ln 333 TestCaseRepository.java

        ResultSummary newResultSummary =
            getResultSummary(
                testCase, testCaseResult.getTimestamp(), testCaseResult.getTestCaseStatus());
        resultSummaries.add(newResultSummary);
      }

To Reproduce
Add 1 test case result, delete it. You should see

{
    "responseMessage": "An exception with message [Cannot invoke \"org.openmetadata.schema.tests.type.TestCaseResult.getTimestamp()\" because \"testCaseResult\" is null] was thrown while processing request."
}

Expected behavior
Summary should be set to null for the testSuite

Version:

  • OpenMetadata version: 1.2.x
@TeddyCr TeddyCr self-assigned this Jan 24, 2024
@TeddyCr TeddyCr changed the title Delete last test case result throw an error Deleting last test case result throw an error Jan 24, 2024
@harshach harshach moved this to Data Quality - Teddy, Pere, Harsha, Shailesh, Rupesh in Release 1.3.0 Jan 24, 2024
harshach pushed a commit that referenced this issue Jan 28, 2024
* fix: error if no testCaseResult exists when updating testSuite summary state

* fix: add return statement on resultsummaries update
@harshach harshach moved this from Data Quality - Teddy, Pere, Harsha, Shailesh, Rupesh to Done in Release 1.3.0 Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant