Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Service password gets overwritten with '********' when editing connection details (any!) #15169

Closed
mgorsk1 opened this issue Feb 13, 2024 · 0 comments
Assignees
Labels
UI UI specific issues

Comments

@mgorsk1
Copy link
Contributor

mgorsk1 commented Feb 13, 2024

Affected module
UI

Describe the bug
If i define a service connection (for example Trino) and after some time change any property of this service, the connection details are updated but as a side-effect password (or actually any secret within this form) gets overwritten in the db with it's masked form (*******).

To Reproduce

  1. Register service with any user and password. Save.
  2. Go into 'Edit Connection' form.
  3. Edit any connection attribute. Save.
  4. Collect encrypted password from openmetadata db (for postgresql: select * from dbservice_entity)
  5. Run in python:
from cryptography.fernet import Fernet

f = Fernet('myfernetkey')  # fill out with your fernet key
p = 'myserviceconnectionpassword'  # fill out with encrypted password collected from previous point

print(f.decrypt(p))

It will return ******** and your service connection will fail when connecting to underlying service.

Screenshots or steps to reproduce

Expected behavior
Secret values are not overwritten when editing connection details (unless you edit secrets themselves).

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8] 1.3.0
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
This is true for any secret field that is available in service connection password - all of them will be updated with ******.

@chirag-madlani chirag-madlani added the UI UI specific issues label Feb 13, 2024
ShaileshParmar11 added a commit that referenced this issue Feb 17, 2024
…iting connection details (any!) (#15193)

* bug: Service password gets overwritten with '********' when editing connection details (any!) #15169

* handle no change scenario

* added unit test for the change

* fixed failing unit test

* added cypress for edit ingestion form

* fixed failing cypress test
Sachin-chaurasiya pushed a commit that referenced this issue Feb 22, 2024
… connection details (any!) #15169

* handle no change scenario

* added unit test for the change

* fixed failing unit test

* added cypress for edit ingestion form

* fixed failing cypress test

(cherry picked from commit bc34eac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI UI specific issues
Projects
None yet
Development

No branches or pull requests

4 participants