Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt ingestion: Incorrect work assignment of owners #15247

Closed
CapitanHeMo opened this issue Feb 19, 2024 · 4 comments · Fixed by #15261
Closed

dbt ingestion: Incorrect work assignment of owners #15247

CapitanHeMo opened this issue Feb 19, 2024 · 4 comments · Fixed by #15261
Assignees

Comments

@CapitanHeMo
Copy link

CapitanHeMo commented Feb 19, 2024

Affected module
Ingestion Framework?

Describe the bug
The problem I'm facing affects 3 aspects of working with OpenMetadata:

  1. Dbl Ingestion does not find existing users if in (username@yourdomain.com ) there is '.';
  2. Users assigned to dbl Ingestion are not displayed on the search page.
  3. Users assigned to dbt Ingestion are not displayed in the drop-down filter by owner.

To Reproduce

  1. A user with a similar name but replacing the '.' sign with '_' is identified without problems.
[2024-02-19T13:41:51.468+0000] {metadata.py:171} WARNING - Unable to ingest owner from DBT since no user or team was found with name daniil.kotomtsev
[2024-02-19T13:41:51.616+0000] {metadata.py:171} WARNING - Unable to ingest owner from DBT since no user or team was found with name daniil.kotomtsev
[2024-02-19T13:41:52.070+0000] {metadata.py:171} WARNING - Unable to ingest owner from DBT since no user or team was found with name daniil.kotomtsev

Снимок экрана 2024-02-19 в 16 44 51
Снимок экрана 2024-02-19 в 16 44 29
3.
Снимок экрана 2024-02-19 в 17 10 43

Screenshots or steps to reproduce

Expected behavior

  1. I expect users with '.' in (username@yourdomain.com ) will be detected and linked as owners to the tables, if they are available in the system.
    2-3. I expect that users linked to tables using dbt Ingestion will be displayed in the drop-down filter by owner, on the search page in the table(Object) block and on the Profile > "My Data" page.

Version:

  • OS: Ubuntu 22.04
  • Python version: -
  • OpenMetadata version: 1.3.0
  • OpenMetadata Ingestion package version: -

Additional context

  • I use Docker installation with default docker-compose file.
  • For load data from dbt artifacts i use UI solution with load files from S3 storage.
@harshach
Copy link
Collaborator

@OnkarVO7 how are we looking for users?

@OnkarVO7
Copy link
Contributor

@harshach we get the user entity ref by using the get_by_name API here and building the user fqn here

Let me try to reproduce this and see if calling ES here fixes it

@harshach
Copy link
Collaborator

@OnkarVO7 if the name contains "." or any entity contains "." in its name we should escape it for FQN.
@pmbrull is hte ingestion framework does the escape during the construction of FQN?

@pmbrull
Copy link
Collaborator

pmbrull commented Feb 20, 2024

@harshach we use antlr as well to build and quote it

OnkarVO7 added a commit that referenced this issue Feb 20, 2024
* Fixed dbt owners with dot

* fixed pytests

* Fixed pytest2

* rmv type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants