Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Classifications or Tags shouldn't be visible in UI #18007

Closed
Prajwal214 opened this issue Sep 26, 2024 · 0 comments · Fixed by #18242
Closed

Disabled Classifications or Tags shouldn't be visible in UI #18007

Prajwal214 opened this issue Sep 26, 2024 · 0 comments · Fixed by #18242
Assignees
Labels
bug Something isn't working customer

Comments

@Prajwal214
Copy link
Contributor

Affected module
Does it impact the UI, backend or Ingestion Framework?
-- UI

Describe the bug
A clear and concise description of what the bug is.
-- We have disabled default Classification Tag shipped with OM, but these are visible in the drop down when tags are assigned.

To Reproduce

Screenshots or steps to reproduce

image image

Expected behavior
A clear and concise description of what you expected to happen. - Tag should not be visible in the drop down when disabled

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8] v1.5.4
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

@Prajwal214 Prajwal214 added bug Something isn't working customer labels Sep 26, 2024
@harshach harshach changed the title Disabled Classification Tag are visible in Drop down Disabled Classifications or Tags shouldn't be visible in UI Oct 13, 2024
harshach added a commit that referenced this issue Oct 19, 2024
…UI (#18242)

* Fix #18007: Disabled Classifications or Tags shouldn't be visible in UI

* added playwright test for disabled tags should not be visible while search

* replace testing tag to new generated one to avoid flakyness

* added test for checking tags are re-enabling it from disabled state

* fix the playwright test for the wrong column selector

---------

Co-authored-by: Ashish Gupta <ashish@getcollate.io>
harshach added a commit that referenced this issue Nov 3, 2024
…UI (#18242)

* Fix #18007: Disabled Classifications or Tags shouldn't be visible in UI

* added playwright test for disabled tags should not be visible while search

* replace testing tag to new generated one to avoid flakyness

* added test for checking tags are re-enabling it from disabled state

* fix the playwright test for the wrong column selector

---------

Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants