Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup postgres lineage and usage #9919

Closed
pmbrull opened this issue Jan 25, 2023 · 8 comments
Closed

Cleanup postgres lineage and usage #9919

pmbrull opened this issue Jan 25, 2023 · 8 comments
Labels
cleanup Code clean up task good-first-issue Good for newcomers Ingestion

Comments

@pmbrull
Copy link
Collaborator

pmbrull commented Jan 25, 2023

The postgres/lineage.py file is not following the same approach as the rest of lineage sources (example).

The process_table_query is not returning the same object that it says it does.

We should try to align as much as possible this logic here taking Snowflake as an example

@pmbrull pmbrull added good-first-issue Good for newcomers Ingestion cleanup Code clean up task labels Jan 25, 2023
@TonyTumba08
Copy link

I'd like to start taking a look at this issue, could you please assign it to me? @pmbrull

@pmbrull
Copy link
Collaborator Author

pmbrull commented Feb 21, 2023

done, thanks!

@TonyTumba08
Copy link

I saw on the readme that you guys have a slack where I can potentially ask for help on getting started, however that slack doesn't seem to work anymore. Is there a new up to date link or do you guys not use slack anymore?

@pmbrull
Copy link
Collaborator Author

pmbrull commented Feb 23, 2023

Hi @TonyTumba08, which link are you following? Just checked and https://slack.open-metadata.org/ is redirecting me properly 🤔

@TonyTumba08
Copy link

Sorry for the late reply, I've been quite busy the past few weeks. You're right though the link does seem to be working now, slack might've been done when I was trying to open it before.

@TonyTumba08 TonyTumba08 removed their assignment Apr 2, 2023
@harshach harshach removed this from Release 1.0 Apr 25, 2023
@harshach harshach moved this to Ingestion in Release 1.1 May 8, 2023
@harshach harshach added this to Backlog May 9, 2023
@harshach harshach removed this from Release 1.1 May 9, 2023
@BarOffn
Copy link

BarOffn commented Jul 30, 2023

Hey @harshach,
Is this still relevant? I'd like to take a look at this issue
If so, could you assign it to me?

@pmbrull
Copy link
Collaborator Author

pmbrull commented Jul 31, 2023

hi @BarOffn, thanks for the ping. Assigned it to you. Let us know if you have any questions

@BarOffn BarOffn removed their assignment Aug 19, 2023
@TomBushell
Copy link
Contributor

I would like to work on this issue. Could I get assigned?

@github-project-automation github-project-automation bot moved this to Done in Backlog Dec 15, 2023
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this issue Dec 15, 2023
…ion in postgres query_parser (open-metadata#13678)

* Replaced s.query with query_text in filters for clarity

* Removed redundant _iter function

* Updated process_table_query to return None when there are no queries to process

* Modified process_table_query to yield None if there are no queries

* Resolved formating issues and modified process_table_query to return None instead of yielding None

* pylint, fix bugs and improve code

* fix import

* pyformat

---------

Co-authored-by: ulixius9 <mayursingal9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code clean up task good-first-issue Good for newcomers Ingestion
Projects
Status: Done
Development

No branches or pull requests

4 participants