Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix Doc] Updating Docker Deployment Doc with the prerequisites #12214

Conversation

dhruvinmaniar123
Copy link
Contributor

Describe your changes:

Fixed: issue #12110

  • What changes did you make? -> While using the env file for deploying using docker compose then there are some prerequisite which needs to follow mentioned in the issue Docker Compose Ingestion Container Bootstrap Error #12110.

  • Why did you make them? -> One of the community user was facing issue when passing an custom password which includes the special characters.

Type of change:

  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to test June 28, 2023 15:50 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to test June 28, 2023 15:50 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to test June 28, 2023 15:50 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to test June 28, 2023 15:50 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to test June 28, 2023 15:50 — with GitHub Actions Inactive
@dhruvinmaniar123 dhruvinmaniar123 temporarily deployed to test June 28, 2023 15:50 — with GitHub Actions Inactive
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 28, 2023
@github-actions github-actions bot added devops safe to test Add this label to run secure Github workflows on PRs labels Jun 28, 2023
@dhruvinmaniar123 dhruvinmaniar123 changed the title [Fix Docs] Updating Docker Deployment Doc with the prerequisites [Fix Doc] Updating Docker Deployment Doc with the prerequisites Jun 28, 2023
@github-actions github-actions bot removed the devops label Jun 28, 2023
@dhruvinmaniar123 dhruvinmaniar123 self-assigned this Jun 28, 2023
@harshach
Copy link
Collaborator

@dhruvinmaniar123 lets make we are using a Warning block to indicate this note, not just another bullet point another

@dhruvinmaniar123
Copy link
Contributor Author

@dhruvinmaniar123 lets make we are using a Warning block to indicate this note, not just another bullet point another

Thanks @harshach. I have updated the same.

@dhruvinmaniar123 dhruvinmaniar123 merged commit 9806a91 into open-metadata:main Jun 29, 2023
harshach pushed a commit that referenced this pull request Jun 30, 2023
* [Fix Docs] Updating Docker Deployment Doc with the prerequisites

* [Fix Docs] Updating Docker Deployment Doc with the prerequisites

---------

Co-authored-by: Dhruvin Maniar <dhruvinmaniar@Dhruvins-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops documentation Improvements or additions to documentation safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants