Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #12771: Added Greenplum Ingestion Connector #13128

Merged
merged 6 commits into from
Oct 4, 2023
Merged

fixes #12771: Added Greenplum Ingestion Connector #13128

merged 6 commits into from
Oct 4, 2023

Conversation

T01iK
Copy link
Contributor

@T01iK T01iK commented Sep 10, 2023 •
edited
Loading

Describe your changes:

fixes #12771 : Added Greenplum Ingestion Connector (based on Postgres connector from OpenMetadata 1.1 but queries updated to support Greenplum).
Tested on Greenplum v6

  • What changes did I make?
    Added Greenplum connector in Ingestion, Test Connection Service, UI, JsonSchema
  • Why did you make them?
    Connector was needed to support Greenplum in my project
  • How did you test your changes?
    Using Metadata CLI and Airflow on production Greenplum in my company

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

@github-actions github-actions bot added UI UI specific issues Ingestion backend labels Sep 10, 2023
@github-actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@T01iK T01iK changed the title Fixes ISSUE-12771: Added Greenplum Ingestion Connector Fixes #12771: Added Greenplum Ingestion Connector Sep 10, 2023
@T01iK T01iK changed the title Fixes #12771: Added Greenplum Ingestion Connector fixes #12771: Added Greenplum Ingestion Connector Sep 10, 2023
@harshach harshach added the safe to test Add this label to run secure Github workflows on PRs label Sep 10, 2023
@T01iK T01iK temporarily deployed to test September 11, 2023 02:38 — with GitHub Actions Inactive
@T01iK T01iK temporarily deployed to test September 11, 2023 02:38 — with GitHub Actions Inactive
@evmuravev
Copy link

evmuravev commented Sep 26, 2023 •
edited
Loading

@chirag-madlani @karanh37 Could you please also review and give the approve for this pull request? We are really looking forward to the support of Greenplum in OpenMetadata 🙏

@chirag-madlani
Copy link
Collaborator

@evmuravev @T01iK Can you resolve the conflicts here?

chirag-madlani
chirag-madlani previously approved these changes Sep 26, 2023
View reviewed changes
@T01iK T01iK dismissed stale reviews from chirag-madlani and harshach via 5eaa648 September 29, 2023 16:32
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 50%
 50.83% (22696/44649) 31.75% (8381/26397) 31.72% (2616/8248)

@T01iK
Copy link
Contributor Author

T01iK commented Sep 29, 2023

resolved conflicts and retested the connector locally
image
@chirag-madlani @harshach

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023 •
edited
Loading

[open-metadata-ingestion] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
46.1% 46.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@TeddyCr TeddyCr merged commit b788061 into open-metadata:main Oct 4, 2023
16 of 21 checks passed
@pmbrull pmbrull mentioned this pull request Oct 25, 2023
Closed
@saurabhyadav1985 saurabhyadav1985 mentioned this pull request Dec 21, 2023
Merged
9 tasks
@pmbrull pmbrull mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulixius9 ulixius9 ulixius9 approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach harshach left review comments

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees
No one assigned
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no Support greenplum version 6
6 participants
@T01iK @harshach @evmuravev @chirag-madlani @ulixius9 @TeddyCr