Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Druid Profiler failures #13700

Merged
merged 26 commits into from
Oct 25, 2023
Merged

Fixes Druid Profiler failures #13700

merged 26 commits into from
Oct 25, 2023

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Oct 25, 2023

Describe your changes:

  • implement fixes for druid profiler workflow
  • stabilize playwright tests
  • implement redshift, druid, hive playwright tests

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@TeddyCr TeddyCr requested review from akash-jain-10, harshach and a team as code owners October 25, 2023 09:15
@github-actions github-actions bot added documentation Improvements or additions to documentation Ingestion devops safe to test Add this label to run secure Github workflows on PRs labels Oct 25, 2023
pmbrull
pmbrull previously approved these changes Oct 25, 2023
View reviewed changes
@sonarqubecloud
Copy link

[open-metadata-ingestion] Please retry analysis of this Pull-Request directly on SonarCloud.

akash-jain-10
akash-jain-10 previously approved these changes Oct 25, 2023
View reviewed changes
@TeddyCr TeddyCr dismissed stale reviews from akash-jain-10 and pmbrull via 72870b6 October 25, 2023 11:32
@github-actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

43.8% 43.8% Coverage
0.0% 0.0% Duplication

@pmbrull pmbrull merged commit 452a33b into open-metadata:main Oct 25, 2023
15 of 19 checks passed
akash-jain-10 pushed a commit that referenced this pull request Oct 26, 2023
@TeddyCr @pmbrull @akash-jain-10
Fixes Druid Profiler failures (#13700)
7ccaf48 
* fix: updated playwrigth test structure

* fix: druid profiler queries

* fix: python linting

* fix: python linting

* fix: do not compute random sample if profile sample is 100

* fix: updated workflow to test on push

* fix: move connector config to category folder

* fix: updated imports

* fix: added pytest-dependency package

* fix: updated readme.md

* fix: python linting

* fix: updated profile doc for Druid sampling

* fix: empty commit for CI

* fix: added workflow constrain back

* fix: sonar code smell

* fix: added secrets to container

* Update openmetadata-docs/content/v1.2.x-SNAPSHOT/connectors/ingestion/workflows/profiler/index.md

Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com>

* Update openmetadata-docs/content/v1.2.x-SNAPSHOT/connectors/ingestion/workflows/profiler/index.md

Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com>

* Update ingestion/tests/e2e/entity/database/test_redshift.py

* fix: ran pylint

* fix: updated redshift env var.

* fix: import linting

---------

Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@akash-jain-10 akash-jain-10 akash-jain-10 left review comments

@harshach harshach Awaiting requested review from harshach harshach is a code owner

Assignees
No one assigned
Labels
devops documentation Improvements or additions to documentation E2E-testing Ingestion profiler safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeddyCr @akash-jain-10 @pmbrull