Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Description for Data Insights and report app #13714

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Add Description for Data Insights and report app #13714

merged 4 commits into from
Oct 26, 2023

Conversation

mohityadav766
Copy link
Contributor

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this Oct 26, 2023
@mohityadav766 mohityadav766 requested a review from a team as a code owner October 26, 2023 06:34
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Oct 26, 2023
@github-actions github-actions bot added the UI UI specific issues label Oct 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.55% (23205/47792) 30.36% (8612/28366) 30.09% (2642/8781)

@sonarqubecloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit 17f36d1 into main Oct 26, 2023
13 of 15 checks passed
@chirag-madlani chirag-madlani deleted the addAppDescriptions branch October 26, 2023 09:14
@sonarqubecloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

akash-jain-10 pushed a commit that referenced this pull request Oct 26, 2023
@mohityadav766 @karanh37 @akash-jain-10
Add Description for Data Insights and report app (#13714)
4f92042 
* Add Description for Data Insights and report app

* Add Default Empty value for after in logs

* fix: description changes

* fix: restrict to day schedule for external apps

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohityadav766 @chirag-madlani @karanh37