Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cost Analysis Documentation #13739

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Cost Analysis Documentation #13739

merged 5 commits into from
Oct 27, 2023

Conversation

OnkarVO7
Copy link
Contributor

Describe your changes:

Cost Analysis Documentation

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@OnkarVO7 OnkarVO7 requested review from pmbrull and a team October 27, 2023 08:28
@github-actions github-actions bot added documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs labels Oct 27, 2023
TeddyCr
TeddyCr reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@TeddyCr TeddyCr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

OnkarVO7 and others added 3 commits October 27, 2023 15:16
@OnkarVO7 @TeddyCr
Update openmetadata-docs/content/v1.2.x/features/data-insight/cost-an…
6ff7056 
…alaysis.md

Co-authored-by: Teddy <teddy.crepineau@gmail.com>
@OnkarVO7 @TeddyCr
Update openmetadata-docs/content/v1.2.x/features/data-insight/cost-an…
24d6b0b 
…alaysis.md

Co-authored-by: Teddy <teddy.crepineau@gmail.com>
@OnkarVO7 @TeddyCr
Update openmetadata-docs/content/v1.2.x/features/data-insight/cost-an…
f6e7708 
…alaysis.md

Co-authored-by: Teddy <teddy.crepineau@gmail.com>
@OnkarVO7 OnkarVO7 requested a review from TeddyCr October 27, 2023 09:50
TeddyCr
TeddyCr approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@TeddyCr TeddyCr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmbrull pmbrull merged commit c4d13f4 into main Oct 27, 2023
@pmbrull pmbrull deleted the cost_analysis_docs branch October 27, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyCr TeddyCr TeddyCr approved these changes

@pmbrull pmbrull Awaiting requested review from pmbrull

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnkarVO7 @TeddyCr @pmbrull