Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #13382: Replace the user ID with user name in Glossary Term #13753

Merged
merged 5 commits into from
Dec 26, 2023

Conversation

NormanZhang-zzt
Copy link
Contributor

Describe your changes:

Fixes #13382

I worked on replacing the UserId with the User Name because displaying user name could be more intuitive and useful

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added the UI UI specific issues label Oct 28, 2023
@github-actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@chirag-madlani
Copy link
Collaborator

Hi @NormanZhang-zzt Thanks for your contribution. Can you catch displayName using existing method which will use already fetched data for user details if not it will query via API

getUserDisplayName(id?: string, username?: string) {

@chirag-madlani
Copy link
Collaborator

Also can you attach screenshot of your changes will be helpful to review your PR much faster Thanks.

@harshach harshach added the safe to test Add this label to run secure Github workflows on PRs label Dec 26, 2023
chirag-madlani
chirag-madlani previously approved these changes Dec 26, 2023
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
50% (25021/50046) 32.75% (9883/30175) 31.12% (2843/9137)

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit bd50db2 into open-metadata:main Dec 26, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The UI should always display username instead of userid
3 participants