Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): improve file and folder names #13784

Merged
merged 21 commits into from
Nov 10, 2023
Merged

chore(ui): improve file and folder names #13784

merged 21 commits into from
Nov 10, 2023

Conversation

Sachin-chaurasiya
Copy link
Member

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Oct 31, 2023
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Oct 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 49.09% (23664/48202) 30.57% (8852/28961) 30.43% (2684/8821)

@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as draft November 9, 2023 18:52
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review November 10, 2023 07:37
@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 6 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 110 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit 431fbce into main Nov 10, 2023
13 checks passed
@chirag-madlani chirag-madlani deleted the folder-structure-part-1 branch November 10, 2023 11:07
ulixius9 pushed a commit that referenced this pull request Nov 10, 2023
@Sachin-chaurasiya @chirag-madlani @ulixius9
chore(ui): improve file and folder names (#13784)
80f98e9 
* chore(ui): improve file and folder names

* chore: fix test

* fix: build

* Fix paging (#13821)

* chore(ui): pagesize support for all the pagination

* revamp pagination

* complete pagination update

* fix import

* fix pagination

* fix tests

* fix path

* fix import

* fix import error

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sachin-chaurasiya @chirag-madlani