fix: domain assignment for glossary term #13793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
Jest test CoverageUI tests summary
|
|
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!
|
| @@ -143,7 +143,7 @@ const GlossaryPage = () => { | |||
| try { | |||
| const response = await getGlossaryTermByFQN( | |||
| glossaryFqn, | |||
| 'relatedTerms,reviewers,tags,owner,children,votes' | |||
| 'relatedTerms,reviewers,tags,owner,children,votes,domain' | |||
There was a problem hiding this comment.
It will impact cypress tests, Have you verified this locally?
There was a problem hiding this comment.
Yes we are not passing query params in intercept.
chirag-madlani
approved these changes
Nov 2, 2023
karanh37
added a commit
that referenced
this pull request
Nov 8, 2023
chirag-madlani
pushed a commit
that referenced
this pull request
Nov 10, 2023
(cherry picked from commit bb15629)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #13792
I worked on ... because ...
Screen.Recording.2023-10-31.at.6.35.18.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>