Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revamp(ui): whats new alert box popup #13835

Merged
merged 6 commits into from
Nov 4, 2023
Merged

revamp(ui): whats new alert box popup #13835

merged 6 commits into from
Nov 4, 2023

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Nov 2, 2023 •
edited
Loading

Issue #13055

Describe your changes:

  • I worked on revamping whats new alert box popup
  • Fix the typo error in the activity feed
image
Screen.Recording.2023-11-03.at.1.01.41.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 self-assigned this Nov 2, 2023
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 2, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 49.01% (23430/47803) 30.83% (8793/28518) 30.49% (2673/8766)

ShaileshParmar11
ShaileshParmar11 requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes will impact all the cypress test case, can you please verify and update it.

openmetadata-ui/src/main/resources/ui/src/assets/img/update.gif Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/assets/svg/ic-share.svg Show resolved Hide resolved
...adata-ui/src/main/resources/ui/src/components/Modals/WhatsNewModal/WhatsNewModal.styles.less Outdated Show resolved Hide resolved
...adata-ui/src/main/resources/ui/src/components/Modals/WhatsNewModal/WhatsNewModal.styles.less Outdated Show resolved Hide resolved
...adata-ui/src/main/resources/ui/src/components/Modals/WhatsNewModal/WhatsNewModal.styles.less Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json Outdated Show resolved Hide resolved
@Ashish8689
Copy link
Contributor Author

Ashish8689 commented Nov 3, 2023 •
edited
Loading

@ShaileshParmar11 changes made as per comments!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 3, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit 797eed5 into main Nov 4, 2023
12 of 13 checks passed
@chirag-madlani chirag-madlani deleted the whats-new-popup branch November 4, 2023 07:08
Ashish8689 added a commit that referenced this pull request Nov 6, 2023
@Ashish8689
revamp(ui): whats new alert box popup (#13835)
92748ef 
* revamp whats new popup alert box

* changes as per comments

* added await for whats-new-alert in cypress and slow down gif loader

* changes as per comments

* minor changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashish8689 @chirag-madlani @ShaileshParmar11