Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 1.2.1 migration files and postgres migration fixes #13837

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

OnkarVO7
Copy link
Contributor

@OnkarVO7 OnkarVO7 commented Nov 3, 2023

Describe your changes:

Fixes below postgres migration error

2023-11-03 01:59:37 20:29:37.670 [main] INFO  o.o.s.m.a.MigrationWorkflow - [MigrationProcess] Running Schema Changes, Version: 1.2.0, DatabaseType: ConnectionType{name='POSTGRES'driver='org.postgresql.Driver'}, FileName: /opt/openmetadata/./bootstrap/sql/migrations/native/1.2.0/postgres/schemaChanges.sql
2023-11-03 01:59:37 20:29:37.828 [main] ERROR o.o.s.m.u.v.MigrationUtil - Failed to run sql -- rename viewParsingTimeoutLimit for queryParsingTimeoutLimit
2023-11-03 01:59:37 UPDATE ingestion_pipeline_entity
2023-11-03 01:59:37 SET json = jsonb_set(
2023-11-03 01:59:37   json::jsonb #- '{sourceConfig,config,viewParsingTimeoutLimit}',
2023-11-03 01:59:37   '{sourceConfig,config,queryParsingTimeoutLimit}',
2023-11-03 01:59:37   (json #> '{sourceConfig,config,viewParsingTimeoutLimit}')::jsonb,
2023-11-03 01:59:37   true
2023-11-03 01:59:37 )
2023-11-03 01:59:37 WHERE json #>> '{pipelineType}' = 'metadata' due to org.jdbi.v3.core.statement.UnableToExecuteStatementException: org.postgresql.util.PSQLException: ERROR: null value in column "id" of relation "ingestion_pipeline_entity" violates not-null constraint
2023-11-03 01:59:37   Detail: Failing row contains (null, null, null, null, null, null, 2adae549e9afec0f32aae81dfcd0a575.a8c3c627e777063d25d565df1a868d2..., null). [statement:"-- rename viewParsingTimeoutLimit for queryParsingTimeoutLimit
2023-11-03 01:59:37 UPDATE ingestion_pipeline_entity
2023-11-03 01:59:37 SET json = jsonb_set(
2023-11-03 01:59:37   json::jsonb #- '{sourceConfig,config,viewParsingTimeoutLimit}',
2023-11-03 01:59:37   '{sourceConfig,config,queryParsingTimeoutLimit}',
2023-11-03 01:59:37   (json #> '{sourceConfig,config,viewParsingTimeoutLimit}')::jsonb,
2023-11-03 01:59:37   true
2023-11-03 01:59:37 )
2023-11-03 01:59:37 WHERE json #>> '{pipelineType}' = 'metadata'", arguments:{positional:{}, named:{}, finder:[]}]

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@OnkarVO7 OnkarVO7 requested review from a team November 3, 2023 06:17
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 3, 2023
@ulixius9 ulixius9 merged commit 2fdb1af into main Nov 6, 2023
9 of 10 checks passed
@ulixius9 ulixius9 deleted the postgres_mig_fix branch November 6, 2023 12:43
OnkarVO7 added a commit that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants