Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add support for callout in block editor #13839

Merged
merged 15 commits into from
Nov 20, 2023
Merged

feat(ui): add support for callout in block editor #13839

merged 15 commits into from
Nov 20, 2023

Conversation

Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented Nov 3, 2023 •
edited
Loading

Describe your changes:

Part of #13715

I worked on adding support for callout in block editor.

Screen.Recording.2023-11-20.at.6.03.18.PM.mov

Type of change:

  • New feature

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Nov 3, 2023
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 3, 2023
@Sachin-chaurasiya Sachin-chaurasiya mentioned this pull request Nov 3, 2023
Closed
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.67% (23649/48587) 30.4% (8860/29149) 30.2% (2679/8872)

chirag-madlani
chirag-madlani reviewed Nov 4, 2023
View reviewed changes
Copy link
Collaborator

@chirag-madlani chirag-madlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we need to work on Callout Layout a bit. Let's check with Rupesh on this

openmetadata-ui/src/main/resources/ui/src/components/BlockEditor/block-editor.less Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/BlockEditor/block-editor.less Outdated Show resolved Hide resolved
@harshach
Copy link
Collaborator

harshach commented Nov 9, 2023

@Sachin-chaurasiya whats remaining for this?

@Sachin-chaurasiya
Copy link
Member Author

@Sachin-chaurasiya whats remaining for this?

@harshach,need to improve the design and this will be part of 1.3

@open-metadata open-metadata locked and limited conversation to collaborators Nov 9, 2023
@open-metadata open-metadata unlocked this conversation Nov 9, 2023
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as draft November 9, 2023 18:50
@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review November 20, 2023 12:36
@harshach harshach merged commit 7b12ad4 into main Nov 20, 2023
21 of 22 checks passed
@harshach harshach deleted the block-editor-callout branch November 20, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach harshach approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
block-editor safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sachin-chaurasiya @harshach @chirag-madlani