Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC-FIX] Update docs of keycloak SSO #13842

Merged
merged 1 commit into from
Nov 6, 2023
Merged

[DOC-FIX] Update docs of keycloak SSO #13842

merged 1 commit into from
Nov 6, 2023

Conversation

dhruvinmaniar123
Copy link
Contributor

Updating keycloak SSO doc:

  • Removing creating secrets information as we don't require it anymore and it is now deprecated.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@dhruvinmaniar123 dhruvinmaniar123 self-assigned this Nov 3, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation devops safe to test Add this label to run secure Github workflows on PRs labels Nov 3, 2023
@dhruvinmaniar123 dhruvinmaniar123 enabled auto-merge (squash) November 3, 2023 11:35
@dhruvinmaniar123 dhruvinmaniar123 merged commit f89b52c into main Nov 6, 2023
10 checks passed
@dhruvinmaniar123 dhruvinmaniar123 deleted the update/doc-sso branch November 6, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 akash-jain-10 approved these changes

@pmbrull pmbrull Awaiting requested review from pmbrull

@tutte tutte Awaiting requested review from tutte

Assignees

@dhruvinmaniar123 dhruvinmaniar123

Labels
devops documentation Improvements or additions to documentation safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvinmaniar123 @akash-jain-10