Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chore): UI feedback fixes #13859

Merged
merged 7 commits into from
Nov 8, 2023
Merged

fix(chore): UI feedback fixes #13859

merged 7 commits into from
Nov 8, 2023

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

  • I worked on fixing UI issues based on feedback

Issue :
image
image

Resolved:
image
image
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 self-assigned this Nov 6, 2023
@Ashish8689 Ashish8689 added the UI UI specific issues label Nov 6, 2023
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 6, 2023
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
48.98% (23430/47837) 30.79% (8794/28561) 30.46% (2670/8766)

Copy link

sonarqubecloud bot commented Nov 8, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
3.7% 3.7% Duplication

@chirag-madlani chirag-madlani merged commit ab0840a into main Nov 8, 2023
14 checks passed
@chirag-madlani chirag-madlani deleted the ui-fixes-2 branch November 8, 2023 12:27
Ashish8689 added a commit that referenced this pull request Nov 8, 2023
* fix(chore): change errorplaceholder in explore and added tooltip around url style url

* supported helper text in add form for glossary and classification tags

* created separate formLabel component

* minor changes

* changes as per comments

(cherry picked from commit ab0840a)
chirag-madlani pushed a commit that referenced this pull request Nov 10, 2023
* fix(chore): change errorplaceholder in explore and added tooltip around url style url

* supported helper text in add form for glossary and classification tags

* created separate formLabel component

* minor changes

* changes as per comments

(cherry picked from commit ab0840a)
(cherry picked from commit 3427e3b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants