Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use aggregation search instead of suggest query #13861

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

karanh37
Copy link
Contributor

@karanh37 karanh37 commented Nov 6, 2023

Describe your changes:

Fixes #13804

I worked on ... because ...

Screen.Recording.2023-11-06.at.8.55.47.PM.mov

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 6, 2023
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
49% (23408/47774) 30.82% (8787/28509) 30.46% (2668/8759)

Copy link

sonarqubecloud bot commented Nov 6, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

hasMore: false,
};
});
// }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

@chirag-madlani chirag-madlani merged commit 51f3d31 into main Nov 7, 2023
12 of 14 checks passed
@chirag-madlani chirag-madlani deleted the issue-13804 branch November 7, 2023 09:52
karanh37 added a commit that referenced this pull request Nov 8, 2023
* fix: use searchAggregates instead of suggest query

* fix: aggregation fields
chirag-madlani pushed a commit that referenced this pull request Nov 10, 2023
* fix: use searchAggregates instead of suggest query

* fix: aggregation fields

(cherry picked from commit 1ea2e68)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Advanced Search, Unable to choose [Database == ] String that is not in the truncated dropdown list.
2 participants