Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Trino Dialect Import issue #13869

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix Trino Dialect Import issue #13869

merged 1 commit into from
Nov 7, 2023

Conversation

ayush-shah
Copy link
Member

@ayush-shah ayush-shah commented Nov 7, 2023 •
edited
Loading

Describe your changes:

Fixes import error caused

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ayush-shah ayush-shah requested a review from a team as a code owner November 7, 2023 06:20
@ayush-shah ayush-shah added the safe to test Add this label to run secure Github workflows on PRs label Nov 7, 2023
@ayush-shah ayush-shah self-assigned this Nov 7, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@ayush-shah ayush-shah merged commit ec6184d into main Nov 7, 2023
17 of 20 checks passed
@ayush-shah ayush-shah deleted the fix-import-error branch November 7, 2023 06:41
ayush-shah added a commit that referenced this pull request Nov 9, 2023
@ayush-shah
Fix Trino Dialect Import issue (#13869)
cb0a497
chirag-madlani pushed a commit that referenced this pull request Nov 10, 2023
@ayush-shah @chirag-madlani
Fix Trino Dialect Import issue (#13869)
5a041e2 
(cherry picked from commit cb0a497)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OnkarVO7 OnkarVO7 OnkarVO7 approved these changes

Assignees

@ayush-shah ayush-shah

Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayush-shah @OnkarVO7