Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate Assignees while adding posts to a thread #13882

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Populate Assignees while adding posts to a thread #13882

merged 1 commit into from
Nov 7, 2023

Conversation

mohityadav766
Copy link
Contributor

Describe your changes:

Ref : We are not getting the proper entity reference of assignees after a POST call is made for creating the Conversation in Tasks.
API : /api/v1/feed/6843e4f3-6b25-49b2-ad7c-bb6331f5b0d0/posts cc @Ashish8689

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 added backend safe to test Add this label to run secure Github workflows on PRs labels Nov 7, 2023
@mohityadav766 mohityadav766 self-assigned this Nov 7, 2023
@mohityadav766 mohityadav766 requested a review from a team as a code owner November 7, 2023 12:58
@mohityadav766 mohityadav766 merged commit 5989b99 into main Nov 7, 2023
@mohityadav766 mohityadav766 deleted the populateAssigneeFix branch November 7, 2023 13:01
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

mohityadav766 added a commit that referenced this pull request Nov 7, 2023
@mohityadav766
Populate Assignees while adding posts to a thread (#13882)
dd1e268 
(cherry picked from commit 5989b99)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashish8689 Ashish8689 Ashish8689 approved these changes

@harshach harshach Awaiting requested review from harshach

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohityadav766 @Ashish8689