Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Rules with same name in a Policy #13883

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Prevent Rules with same name in a Policy #13883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/PolicyRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
import java.util.ArrayList;
import java.util.Comparator;
import java.util.List;
import java.util.Set;
import java.util.stream.Collectors;
import javax.ws.rs.BadRequestException;
import lombok.extern.slf4j.Slf4j;
import org.jdbi.v3.sqlobject.transaction.Transaction;
import org.openmetadata.schema.entity.policies.Policy;
Expand Down Expand Up @@ -158,6 +160,15 @@ public void entitySpecificUpdate() {
}

private void updateRules(List<Rule> origRules, List<Rule> updatedRules) {
// Check if the Rules have unique names
if (!nullOrEmpty(updatedRules)) {
Set<String> ruleNames = updatedRules.stream().map(Rule::getName).collect(Collectors.toSet());

if (ruleNames.size() != updatedRules.size()) {
throw new BadRequestException("Policy contains duplicate Rules. Please use unique name for Rules.");
}
}

// Record change description
List<Rule> deletedRules = new ArrayList<>();
List<Rule> addedRules = new ArrayList<>();
Expand Down
Loading