Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): fix search not working in roles input in user profile page #13897

Merged
merged 4 commits into from
Nov 8, 2023
Merged

fix(ui): fix search not working in roles input in user profile page #13897

merged 4 commits into from
Nov 8, 2023

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes #13895

  • I worked on fixing the search not working in roles input in the user profile page
Screen.Recording.2023-11-08.at.3.56.47.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Nov 8, 2023
@Ashish8689 Ashish8689 self-assigned this Nov 8, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.96% (23417/47824) 30.79% (8790/28547) 30.44% (2668/8764)

@Ashish8689 Ashish8689 marked this pull request as draft November 8, 2023 11:05
@Ashish8689 Ashish8689 marked this pull request as ready for review November 8, 2023 11:06
Sachin-chaurasiya
Sachin-chaurasiya requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, thanks

openmetadata-ui/src/main/resources/ui/src/utils/CommonUtils.tsx Outdated Show resolved Hide resolved
@Ashish8689
Copy link
Contributor Author

@Sachin-chaurasiya changes made as per comments!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@harshach harshach merged commit 2adce10 into main Nov 8, 2023
14 checks passed
@harshach harshach deleted the user-roles-fix branch November 8, 2023 16:20
Ashish8689 added a commit that referenced this pull request Nov 9, 2023
@Ashish8689
fix(ui): fix search not working in roles input in user profile page (#…
5407b4e 
…13897)

* fix search in roles input in user profile page

* minor change

* changes as per comments

* minor changes

(cherry picked from commit 2adce10)
chirag-madlani pushed a commit that referenced this pull request Nov 10, 2023
@Ashish8689 @chirag-madlani
fix(ui): fix search not working in roles input in user profile page (#…
535e8c6 
…13897)

* fix search in roles input in user profile page

* minor change

* changes as per comments

* minor changes

(cherry picked from commit 2adce10)
(cherry picked from commit 5407b4e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search in Roles input is not working in User Profile Page
4 participants
@Ashish8689 @chirag-madlani @Sachin-chaurasiya @harshach